Bugs report for Markup* in TW 2.0.7

2 views
Skip to first unread message

BramChen

unread,
Apr 6, 2006, 1:40:04 AM4/6/06
to TiddlyWikiDev
Hi Jeremy,

There are some issues i'd found in TW 2.0.7.

If *MarkupPostBody* contains some HTML elements, such as <div>,
<span>...,etc, as i have been saving changs second time will cause to
lose the contains between *<!--POST-BODY-START-->* and
*<!--POST-BODY-END-->* in saved document, and also
*<!--POST-BODY-START-->* itself.

As TW started with *safe mode*, the external scripts in *MarkupPreHead*
or *MarkupPreBody* are still loaded. This doesn't seem to make sense.

(WinXPSP2/ Firefox 1.5.01/ no plugins)

--
Bram

Simon Baird

unread,
Apr 6, 2006, 2:55:05 AM4/6/06
to Tiddly...@googlegroups.com
Yeah it does that for me also. I tried putting my adsense code in there and got exactly then same behaviour as Bram.

Jeremy Ruston

unread,
Apr 6, 2006, 5:21:41 AM4/6/06
to Tiddly...@googlegroups.com
> If *MarkupPostBody* contains some HTML elements, such as <div>,
> <span>...,etc, as i have been saving changs second time will cause to
> lose the contains between *<!--POST-BODY-START-->* and
> *<!--POST-BODY-END-->* in saved document, and also
> *<!--POST-BODY-START-->* itself.

Looking at the code i think there's definitely a bug that would break
if the string "</div>" were in MarkPostBody. I couldn't get it to
misbehave with HTML code that didn't include "</div>" though.

> As TW started with *safe mode*, the external scripts in *MarkupPreHead*
> or *MarkupPreBody* are still loaded. This doesn't seem to make sense.

Hmmm I've barely got a chance to stop them loading. Perhaps for
MarkupPre/PostHead we could wrap the spliced content in a javascript
if() statement, but of course that technique wouldn't stop script
inside of <script> tags from executing in MarkupPostBody, for example.

Does anyone have any bright ideas how this could be done?

Cheers

Jeremy

--
Jeremy Ruston
mailto:jer...@osmosoft.com
http://www.tiddlywiki.com

Reply all
Reply to author
Forward
0 new messages