Bug: Permalinks to tiddlers with commas in name

2 views
Skip to first unread message

andrewg_oz

unread,
Dec 8, 2007, 10:11:45 AM12/8/07
to TiddlyWikiDev
I've just discovered a bug relating to tiddlers with commas in their
name.

A tiddler with a name like "Test,Name" will get a permalink "Test
%2CName". That's fine. The problem is when you go to that permalink
TiddlyWiki looks for "Test%2CName" instead of "Test,Name".

The reason is because config.commands.permalink.handler uses
encodeURIComponent, while getParameters uses decodeURI (without the
Component). For some reason the -Component pair of functions process
commas (and possibly other characters) while the non-Component pair
don't.

The fix is to ensure these two bits of code both use the same
Component/non-Components pairs of encodeURI/decodeURI. I don't know
which is best, so I'll leave that decision to more knowledgeable
people...

andrewg_oz

unread,
Dec 22, 2007, 10:42:05 AM12/22/07
to TiddlyWikiDev
OK ... Where else should I report this bug?

FND

unread,
Dec 22, 2007, 11:00:35 AM12/22/07
to Tiddly...@googlegroups.com
That's a good catch, thanks!

> OK ... Where else should I report this bug?

I've created a ticket:
http://trac.tiddlywiki.org/ticket/436


-- F.

andrewg_oz

unread,
Dec 24, 2007, 6:21:12 AM12/24/07
to TiddlyWikiDev
> I've created a ticket:

Thanks!
Reply all
Reply to author
Forward
0 new messages