Re: Bug + fix for Desert 0.3.4

0 views
Skip to first unread message

Brian Takita

unread,
Mar 31, 2009, 11:46:37 PM3/31/09
to Simon Russell, pivotallab...@googlegroups.com
Hello Russel, thanks for the patch.

I'm forwarding your email to our public open source email list.

On Tue, Mar 31, 2009 at 7:49 AM, Simon Russell <si...@bellyphant.com> wrote:
> Hi there,
>
> I'm sorry, I've no idea what the appropriate way to do this is; I
> could send you a patch, but I haven't used Git much.  (Still stuck
> with Subversion here).
>
> I noticed that migrating down on Rails 2.2 appears to be broken, the
> SQL you're using to update the plugin_migrations table has two WHERE
> clauses, which dies.
>
> I checked on Github, this bug still appears to be there:
> http://github.com/pivotal/desert/blob/13dbfc1c40796499a756dbcdf5fe97d3f934110e/lib/desert/plugin_migrations/2.1/migrator.rb
>
> Obviously it's just that the second WHERE needs to be an AND.
>
> Otherwise, Desert is great, very happy it's allowed us to move to
> Rails 2.2 much more easily than Engines would have.
>
> Simon Russell
>

Reply all
Reply to author
Forward
0 new messages