New REST server project - peer review and feedback

[Ivo M]

Hello everyone,

I have recently pushed to GitHub a small library that allows for easy creation of RESTfull services.

I will be at the Boston PHP meetup next week, Nov the 12th, and presenting it there in  a short 15 min talk.

It would be great if I can get some feedback from the local group here in VT.

Any feedback is appreciated!

Thanks and Regards!

-Ivo

Here is a link to the project's web site: http://ivolator.github.io/restlt

[Ben Glassman]

Nice library Ivo,

Looks like a nice self-container solution for http routing. Just some general thoughts reviewing it quickly.

1. You could consider using the Symfony HttpFoundation component for the abstraction of request/response. It is becoming somewhat of a standard library for this, being used in many open source projects.

2. Consider adding a registerResource method to server so the user could register an instance of a resource rather than the class name. This would allow configuration of the instance via constructor parameters.

3. Could Resource be an Interface rather than requiring that you extend the RestIt resource?

4. You could move the event handling (before/after/error) into a separate class or use an existing component such as the symfony event dispatcher to allow for increase flexibility (users could have their own custom events so if something significant occurs at multiple rest endpoints it could trigger a custom event).

5. Consider using the doctrine annotations parser library since its independently maintained and unit-tested, etc.

6. Consider adding unit tests/functional tests. I know for me when I'm evaluating a library for use that is a major requirement.

7. As a possible alternative to having an member variables for response/request in the resource you could inect those into the method when it is called if they are type hinted. For example an action getMe($name, $age) could be defined as getMe(Request $request, $name, $age) in which case it would automatically have the request injected. There are actions  that do not require access to the request and that would make it clear whether they are using it or not. This approach could be used for the onBefore/onAfter (or general events) in that you could pass an array of the route parameters that were going to the method call and the callback could decide what if anything to do with those.

8. You could consider adding annotations to the class itself for onBefore/onAfter/onError and similar to each method that would allow you to configure per-route callbacks.

Its great to see open source library contributions coming out of Vermont, good luck with your presentation!

Regards,

Ben Glassman

[Ivo M]

Hi Ben,

Very thoughtful feedback. Thank you! 

You did point out many of the things I was considering too.

I had the same considerations regarding the HTTP and Event handling by other components, but I dropped it because I didn't want dependencies. Same goes for the Doctrine annotations parser. 

I also didn't want to write a full blown Event manager in order to keep it lighter. Smaller footprint was one of the goals.

I thought about using annotations for the events,but I think that there are limitations to it. Also I wanted to limit the use of annotations in order to have less meta data. 

With the way events are currently setup, you can have the same event before and after the routing for each method per resource. I think that's what #8 asking for and it is actually there. However it would make sense to have a global application pre and post route events.

The unit tests are in progress and not as much fun to write as the project itself :)

# 2 and #3 are great suggestions! Although I won't get away without having base class for Resource. But adding an interface is definitely needed.

 

Thanks again!

-Ivo

[Kobbi Ryan]

Quality LSD | Buy 1P-LSD Pickle rick 300Ug and LSD 300ug deadhead chemist in USA



https://t.me/psychobinstore
https://t.me/psychobinstore
https://t.me/psychobinstore

buy lsd gel tabs online, acid gel tabs for sale, buy lsd online, acid tabs for sale online, best lsd gel tabs for sale online,

https://t.me/psychobinstore
https://t.me/psychobinstore
https://t.me/psychobinstore

The sale of LSD (lysergic acid diethylamide) gel tablets has not changed since it was first introduced to the public. People are still using the LSD blotters that Timothy Leary used in the early days.

However, times are changing, and new technologies are being developed to accommodate more LSDs in a single container. Acid gel sheets are a novel method of preparing LSD with several advantages over traditional blotting paper. LSD Gel tablets can contain three times more stimulants than dry ones.

https://t.me/psychobinstore
https://t.me/psychobinstore
https://t.me/psychobinstore

Acid Gel Tabs and LSD Blotters: What's the Difference?

The only difference between LSD gel tablets and LSD blotters (also known as "acid tablets") is that gel tablets contain the LSD in a gelatin base. In contrast, gel tab acid, blotters have the LSD in a particular type of absorbent paper (called blotting paper).

https://t.me/psychobinstore
https://t.me/psychobinstore
https://t.me/psychobinstore

Gel tablets are the next generation of LSD administration. Lasting longer, Mescaline Powder, they can hold more LSDs per 1/4 square inch and cure about 50% faster than regular blotters.

Are LSD Gel tabs the same as Blotters?

Yes, the equipment is the same for the standard blotting papers and the new gel plates. Both types contain high LSD. The results' time frame may differ, but the overall experience is the same. Gel tabs are faster than blotters, and gel tabs drugs, so you may get a more substantial or spiked effect, although most users won't notice the difference. Also, gel tablets contain more LSD and have a more substantial

https://t.me/psychobinstore
https://t.me/psychobinstore

What is the Shelf Life of Gel Tabs for Sale?

One of the main advantages of gel tab LSD is its long life. If it is unknown how long it takes for acid gel tablets to wear off, it is thought to be between 3-6 years. All forms of LSD lose their potency over time, San Pedro Powder For Sale, especially if not properly stored. Knowing how to properly store LSD will help you keep its potency in the long run.

In general, gel tablets should be wrapped in aluminum foil and kept in the refrigerator. Refrigerating the container will extend its shelf life. Do not expose your LSD to high temperatures or direct sunlight for more than a few minutes.