|Amending commit messages non-destructively?||Joshua J. Kugler||10/4/12 4:19 PM|
I had a user ask:
"We were wondering if it is possible to configure (or modify?) Gerrit to allow
pushing patches with amended commit comments (i.e. from "git commit --amend"
that only modifies the commit comments) that does not clear the inspection and
build/test flags on the change? This would allow developers to improve their
commit comments without the extra effort of testing."
In reading the docs and poking around in the config, I don't think this is
currently possible. is this feasible? Is it on a road map? Is these even
desired, as I seem to recall that git best practice was not modifying the
commit message after pushing.
Any comments welcome.
Joshua J. Kugler - Fairbanks, Alaska
Azariah Enterprises - Programming and Website Design
jos...@azariah.com - Jabber: peda...@gmail.com
PGP Key: http://pgp.mit.edu/ ID 0x73B13B6A
|Re: Amending commit messages non-destructively?||Conley Owens||10/4/12 4:24 PM|
A commit message is part of a change. It may warrant approval. I
think it should be up to the build tools you are using to decide
whether or not to carry forward approvals without retesting.
> To unsubscribe, email repo-discuss...@googlegroups.com
> More info at http://groups.google.com/group/repo-discuss?hl=en
|Re: Amending commit messages non-destructively?||Joshua J. Kugler||10/4/12 4:31 PM|
I would tend to agree with you.
The behavior they were interested in was not clearing the inspection flags,
which means it hasn't even gotten to the build/test stage yet.
|Re: Amending commit messages non-destructively?||Conley Owens||10/4/12 4:34 PM|
Is "inspection" your own custom label (like code-review, verified)?
You can create a hook that will carry forward that label when a new
patchset is added.
|Re: Amending commit messages non-destructively?||MartinFick||10/4/12 4:38 PM|
On Thursday, October 04, 2012 05:34:42 pm Conley Owens
> Is "inspection" your own custom label (like code-review,The trivial rebase hook might be what you want, look in
The Qualcomm Innovation Center, Inc. is a member of Code
Aurora Forum, hosted by The Linux Foundation
|Re: Amending commit messages non-destructively?||Luciano Carvalho||10/4/12 5:05 PM|
|RE: Amending commit messages non-destructively?||Pursehouse, David||10/4/12 5:43 PM|
> I seem to recall that git best practice was not modifying the commit message after pushingIn pure git context this probably means pushing into the repository; i.e. a forced push in Gerrit terms. In that case, no, the commit message should not be modified afterwards because it would be "rewriting history". See  about the problems that can cause.
However when working with Gerrit, it's quite common to push a change for review and then, before the change is submitted, push new patch sets in which the commit message is changed.