Huge set of copied plugins on $GERRIT_SITE/tmp

Showing 1-4 of 4 messages
Huge set of copied plugins on $GERRIT_SITE/tmp lucamilanesio 10/8/12 2:55 AM
I have experienced many many many (repeated at least 20-30 times) plug-in jar files copied with different time-stamps into $GERRIT_SITE/tmp.
I know this is explicitly done by the PluginLoader for avoiding the JVM to crash when plugin is "hot" updated and then reloaded.

Does anybody have proposals / ideas / suggestions on how to remove them automatically ?

P.S. Think this is key to be resolved before gerrit-2.5 will be released.

Luca.
Re: Huge set of copied plugins on $GERRIT_SITE/tmp Shawn Pearce 10/8/12 9:50 AM
On Mon, Oct 8, 2012 at 2:54 AM, Luca Milanesio <luca.mi...@gmail.com> wrote:
> I have experienced many many many (repeated at least 20-30 times) plug-in jar files copied with different time-stamps into $GERRIT_SITE/tmp.
> I know this is explicitly done by the PluginLoader for avoiding the JVM to crash when plugin is "hot" updated and then reloaded.
>
> Does anybody have proposals / ideas / suggestions on how to remove them automatically ?

Hmm. I thought we removed them automatically when the plugin was
gracefully stopped by a graceful Gerrit shutdown. But maybe this isn't
true?

We should be able to prune this directory at server startup. Its
supposed to be unique to the site and thus also to the running Gerrit
process. If this Gerrit starts successfully by binding to the ports in
the gerrit.config, no other Gerrit is (probably) running, so we can
prune out any unused JARs.
Re: Huge set of copied plugins on $GERRIT_SITE/tmp lucamilanesio 10/8/12 12:09 PM
Will investigate and fix it in stable-2.5 ;-)

Luca.
Re: Huge set of copied plugins on $GERRIT_SITE/tmp Edwin Kempin 1/8/13 12:33 AM
I've pushed several fixes for this for code review [1,2,3].
We still might do what Shawn suggested and cleanup the tmp folder on Gerrit startup.

[1] https://gerrit-review.googlesource.com/40881
[2] https://gerrit-review.googlesource.com/40858
[3] https://gerrit-review.googlesource.com/40870

2012/10/8 Luca Milanesio <luca.mi...@gmail.com>