Proposal [from github]: Link plugin does not support target (open in new window)

Showing 1-7 of 7 messages
Proposal [from github]: Link plugin does not support target (open in new window) Divio Developers 2/3/11 6:35 AM
https://github.com/divio/django-cms/issues/labels/feature%20request#issue/534
Re: Proposal [from github]: Link plugin does not support target (open in new window) Angelo Dini 2/4/11 12:34 AM
+1

but rather than using target="_blank" implement a tag like {{ render_target }} so u can use target="_{{ render_target }}" to be able to integrate a xhtml strict way of triggering the target.
Example: rel="target:blank" > using js to overwrite target > html valid
Re: Proposal [from github]: Link plugin does not support target (open in new window) centralniak 2/4/11 2:11 AM


2011/2/4 Angelo Dini <atra...@gmail.com>

+1

but rather than using target="_blank" implement a tag like {{ render_target }} so u can use target="_{{ render_target }}" to be able to integrate a xhtml strict way of triggering the target.
Example: rel="target:blank" > using js to overwrite target > html valid

Sure +1.

Would be imo nice, when you could select from predefined values (_self, _blank, _top) or enter custom value when that is needed by the deployment.

Regards,
Piotr
Re: Proposal [from github]: Link plugin does not support target (open in new window) Martin Pajuste 2/11/11 7:02 AM
Definitely +1.
Re: Proposal [from github]: Link plugin does not support target (open in new window) Phoebe Bright 2/16/11 10:42 AM
Definately +2!, I'm finding it very hard to explain to the client why he can't have his link opening in a new window.  I like solution as suggested by centralniak as it is simple for the client to understand.
Re: Proposal [from github]: Link plugin does not support target (open in new window) Bruno Clermont 6/13/11 9:19 AM
there is already a patch for this
it just need 12 characters to get it merged

https://github.com/bendavis78/django-cms-2.0/commit/c08e1c857f2666f5ac51f3b77d1c66c0478d2169
Re: Proposal [from github]: Link plugin does not support target (open in new window) Jonas Obrist 6/13/11 9:32 AM
Fix those 12 characters, send an updated pull request...