I definitely think the manner of adding CSS by using require_css in _config.php is a hack, and we need to provide a better way of adding css to the admin area.
But the general idea of controlling appearance in the admin area via CSS instead of via configuration values is sound, and the method I prefer.
Icons sit right on the boundary of what's content versus what's appearance, so I'm happy either way. I still think CSS is slightly tidier (you can deal with different sized images, different images in different places, etc) but I'm OK if someone raises a patch that adds a config value. I think if we start adding config values for font sizes etc though we've gone to far.
Do I understand correctly that we're going do document Martimiz's solution as the endorsed method for adding a custom icon to your LeftAndMain interface? Maybe it's just me, but something isn't right about that. At worst it looks like a hack, and at best it's a desperate workaround.
I understand the point about not cluttering up our classes with statics, but you've already provided the API for $menu_title and even $url_segment. Why stop there?
I don't know.. that just looks bad to me. If I were shopping around for a CMS and came across that documentation, I'd be a bit nonplussed.
On Wednesday, August 8, 2012 11:53:15 AM UTC-4, Martimiz wrote:
No, I won't :-) I just want to look if there are any other nice things that can be done using styling, besides changing the icon
Yep, pull request for 3.0, please :) Just to be clear: Don't extend that "cms tree" howto, that's a different topic.