New translator: Nore Dame Philosophical Reviews

[Emiliano Heyns]

I'm offering a new translator for Notre Dame Philosophical Reviews for inclusion in Zotero. It is available at https://gist.github.com/anonymous/e41101c10d82091e3622, I am willing to transfer copyright to CHNM.

[Sebastian Karcher]

Thanks!
Would you mind doing this as a pull request and adding a couple of
automated tests (two clicks with Scaffold)?
There might be a couple of small details we'd want changed, but mostly
this should be pretty quick.

> --
> You received this message because you are subscribed to the Google
> Groups "zotero-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to zotero-dev+...@googlegroups.com
> <mailto:zotero-dev+...@googlegroups.com>.
> To post to this group, send email to zoter...@googlegroups.com
> <mailto:zoter...@googlegroups.com>.
> Visit this group at https://groups.google.com/group/zotero-dev.
> For more options, visit https://groups.google.com/d/optout.

[Emiliano Heyns]

I've tried to add tests, but scaffold isn't seeing them:

https://gist.github.com/24251efe97e94fa5248f

[Aurimas Vinckevicius]

The stray semicolons after /** BEGIN TEST CASES **/ and /** END TEST CASES **/ might be confusing Scaffold. You should really be using Scaffold to add the test cases though. Don't type them in manually.

On Mon, Jan 4, 2016 at 9:14 AM, Emiliano Heyns <emilian...@iris-advies.com> wrote:

I've tried to add tests, but scaffold isn't seeing them:

https://gist.github.com/24251efe97e94fa5248f

--

You received this message because you are subscribed to the Google Groups "zotero-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to zotero-dev+...@googlegroups.com.
To post to this group, send email to zoter...@googlegroups.com.

[Emiliano Heyns]

I did enter them through scaffold, but the  source is coffeescript, not javascript. Once I transfer ownership to Zotero I don't mind if the CSisms are removed though. The stray semicolon I can remove.

You received this message because you are subscribed to a topic in the Google Groups "zotero-dev" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/zotero-dev/9gSkgWlJyHc/unsubscribe.
To unsubscribe from this group and all its topics, send an email to zotero-dev+...@googlegroups.com.