Fwd: [WebAPIContrib] Changed BasicAuthenticationHandler to use indexOf method instead a split... (#96)

[Alexander Zeitler]

We need a new NuGet package:

https://github.com/WebApiContrib/WebAPIContrib/pull/96

Alex

Von: Ryan Anderson <notifi...@github.com>
Datum: 5. September 2013 20:54:39 MESZ
An: WebApiContrib/WebAPIContrib <WebAPI...@noreply.github.com>
Betreff: [WebAPIContrib] Changed BasicAuthenticationHandler to use indexOf method instead a split... (#96)
Antwort an: WebApiContrib/WebAPIContrib <reply+i-19067688-8584ebacfc12dc7...@reply.github.com>

... since passwords could contain colons.

According to the RFC (http://www.ietf.org/rfc/rfc2617.txt), it is valid
for the password to contain a colon ':' character.

The change now uses indexOf(':') instead of a Split(':') since it is possible if the password has a colon, would return an array of 3 objects instead of the anticipated 2.

---

You can merge this Pull Request by running

  git pull https://github.com/ryanande/WebAPIContrib master

Or view, comment on, or merge it at:

  https://github.com/WebApiContrib/WebAPIContrib/pull/96

Commit Summary

• Changed BasicAuthenticationHandler to use indexOf method instead a split since passwords could contain colons.

File Changes

• M src/WebApiContrib/MessageHandlers/BasicAuthenticationHandler.cs (7)

Patch Links:

• https://github.com/WebApiContrib/WebAPIContrib/pull/96.patch
• https://github.com/WebApiContrib/WebAPIContrib/pull/96.diff