What happened to our test coverage?

[Leonel Câmara]

For some reason the changes in this pull request reduced our coverage by 15%

https://github.com/web2py/web2py/pull/1844

[Richard Vézina]

This migth help :

https://anonbadger.wordpress.com/2017/11/24/better-unittest-coverage-stats-excluding-code-that-only-executes-on-python-2-3/

On Mon, Feb 26, 2018 at 9:08 AM, Leonel Câmara <leonel...@gmail.com> wrote:

For some reason the changes in this pull request reduced our coverage by 15%

https://github.com/web2py/web2py/pull/1844

--
-- mail from:GoogleGroups "web2py-developers" mailing list
make speech: web2py-developers@googlegroups.com
unsubscribe: web2py-developers+unsubscribe@googlegroups.com
details : http://groups.google.com/group/web2py-developers
the project: http://code.google.com/p/web2py/
official : http://www.web2py.com/
---
You received this message because you are subscribed to the Google Groups "web2py-developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to web2py-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Richard Vézina]

It the b'...', I think : https://codecov.io/gh/web2py/web2py/pull/1844/diff

Quote : A prefix of 'b' or 'B' is ignored in Python 2; it indicates that the literal should become a bytes literal in Python 3 (e.g. when code is automatically converted with 2to3). A 'u' or 'b' prefix may be followed by an 'r' prefix.

https://docs.python.org/2/reference/lexical_analysis.html#string-literals

https://stackoverflow.com/questions/6269765/what-does-the-b-character-do-in-front-of-a-string-literal

So I guess that coverage includes those line which are ignored in coverage computation...

Richard

[Leonel Câmara]

I think it was a coincidence and not due to this pull request, looks like a coverage update changed how the config is supposed to be done. I'll fix it.

[Richard Vézina]

Yes I saw some update passed to testing or coverage recently it might be related to that too...

I can't find any relevant lead with "coverage python and b" neither on the converage repo and issues : https://bitbucket.org/ned/coveragepy/issues?q=b%27

There is this : https://bitbucket.org/ned/coveragepy/issues/591/typeerror-compile-expected-string-without

But it don't seems to be relevant...

Richard

On Mon, Feb 26, 2018 at 1:41 PM, Leonel Câmara <leonel...@gmail.com> wrote:

I think it was a coincidence and not due to this pull request, looks like a coverage update changed how the config is supposed to be done. I'll fix it.

--

[Leonel Câmara]

Yep, just raised our coverage by 18% mainly by making coverage behave like it used to.

https://github.com/web2py/web2py/pull/1873

[Richard Vézina]

Great job... Was the b' string regarded as "error"? as you just remove "ignore_errors = True"

Richard

On Mon, Feb 26, 2018 at 3:13 PM, Leonel Câmara <leonel...@gmail.com> wrote:

Yep, just raised our coverage by 18% mainly by making coverage behave like it used to.

https://github.com/web2py/web2py/pull/1873

--