Backward compatibility and new behavior of _before_ callbacks

59 views
Skip to first unread message

Anthony

unread,
Sep 18, 2017, 12:20:25 PM9/18/17
to web2py-d...@googlegroups.com
Massimo, others, any opinions on https://github.com/web2py/pydal/issues/480#issuecomment-330273607.

To me this looks like a break of backward compatibility (I don't see the old behavior as a bug -- it's just that we now prefer the new behavior).

Even if we believe the old behavior constitutes a bug, that doesn't mean all usages of the functionality in existing apps were therefore buggy and will be corrected by this change. Rather, this change could well be introducing bugs into apps that were functioning perfectly well before the change (it broke at least one user's functioning code). Therefore, if we're going to make changes like this, we should at least document the changes and warn users to make sure they update their app code when updating the framework.

Anthony

Anthony

unread,
Sep 23, 2017, 12:01:35 PM9/23/17
to web2py-developers
Anyone?

Paolo Valleri

unread,
Sep 24, 2017, 4:00:52 AM9/24/17
to web2py-d...@googlegroups.com
I'd go for reverting the changes or if it is to late to document everything changed allowing developers to fix their app in an easier way.

 Paolo

--
-- mail from:GoogleGroups "web2py-developers" mailing list
make speech: web2py-developers@googlegroups.com
unsubscribe: web2py-developers+unsubscribe@googlegroups.com
details : http://groups.google.com/group/web2py-developers
the project: http://code.google.com/p/web2py/
official : http://www.web2py.com/
---
You received this message because you are subscribed to the Google Groups "web2py-developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to web2py-developers+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply all
Reply to author
Forward
0 new messages