[pyDAL][py3] Imap adapter issues

[Giovanni Barillari]

Hi all,

I've got the py3 branch (updated with code from last master) passing all tests, except for imap adapter: https://travis-ci.org/web2py/pydal/builds/59139963

The issue with imap seems to deal with text processing/encoding: https://travis-ci.org/web2py/pydal/jobs/59139997#L174

Is there anybody which knows imap adapter flows better than me who can help solving this?

/Giovanni

[Niphlod]

alan should be the one to contact: I don't think there are many people using imapadapter...tests are also done against a mock: is that supposed to be py3 compatible ?

[Giovanni Barillari]

Good point: I don't know.

So, maybe, right now we can bypass python3 support/tests on imap?

[Niphlod]

I'm maybe the most evil contributor out there.
Something that gets added as "experimental", tested for the 30% and revisited by 1 author only smells like something that should have been a contrib and not a piece of core.
But again, I'm evil.

[Giovanni Barillari]

Well, evil or not I agree with you.

My proposal is:

1) bypass python3 support on imap until we have good tests on it

2) merge py3 branch on master

3) drop python 2.5 support since we agreed about it and remove related code

4) write down in the wiki how to write py2py3 compatible code for contributions on pydal

5) eventually move imap adapter to contrib unless we find out a core developer interested in maintain it (which means port the code to py3, write tests and docs)

@Massimo and everyone else: what do you think?

/Giovanni

--
-- mail from:GoogleGroups "web2py-developers" mailing list
make speech: web2py-d...@googlegroups.com
unsubscribe: web2py-develop...@googlegroups.com
details : http://groups.google.com/group/web2py-developers
the project: http://code.google.com/p/web2py/
official : http://www.web2py.com/
---
You received this message because you are subscribed to a topic in the Google Groups "web2py-developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/web2py-developers/CzjsjXpA78s/unsubscribe.
To unsubscribe from this group and all its topics, send an email to web2py-develop...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Paolo Valleri]

I agree about bypass imap tests (actually, many of them are already marked as 'skip')

as far as py3 is concerned, unfortunately tests are not always enough to check that everything is ok. Given that, before merging I'd ask users in the mail-list to test it with their py2.7 apps. In addition, as usual, rebase the branch before merging it (I think there are too many 'fix commit' :) ).

 Paolo

You received this message because you are subscribed to the Google Groups "web2py-developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to web2py-develop...@googlegroups.com.

[Alan Etkin]

5) eventually move imap adapter to contrib unless we find out a core developer interested in maintain it (which means port the code to py3, write tests and docs)

I'm ok with any of Paolo/Giovanni/Simone proposals about imap. I'm unable to maintain it, so ok about moving it to whatever place you prefer, disabling tests, etc.

[Giovanni Barillari]

Yes, I will rebase the branch.

So maybe we can wait for web2py 2.10.4 release and then merge the py3 branch on master and track that in web2py trunk, so we can ask users to test it.

/Giovanni

[Massimo DiPierro]

+1

So is 2.10.4 ready to release in your opinion?

[Giovanni Barillari]

For what concerns the DAL, yes, I think it's ready.

I don't know if anybody is working on something else.

/Giovanni