[vim/vim] Vim add 'noet' to modeline in documentation (#3263)

46 views
Skip to first unread message

Yee Cheng Chin

unread,
Jul 28, 2018, 8:32:20 PM7/28/18
to vim/vim, Subscribed

This makes sure 'noexpandtab' is on when editing documentation pages to keep formatting consistent regardless of local settings.

A lot of large software companies (e.g. Google) prefers using spaces to tabs. This means expandtab will be set for a large amount of developers. Setting noexpandtab using modeline makes sure contributors won't make mistakes when editing documentations, similar to the already existing tw=78 modeline in docs. Also, the C files in Vim repo already sets noet in the modeline.

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/3263

Commit Summary

  • Vim add 'noet' to modeline in documentation

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

Codecov

unread,
Jul 28, 2018, 8:49:19 PM7/28/18
to vim/vim, Subscribed

Codecov Report

Merging #3263 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3263      +/-   ##
==========================================
+ Coverage   76.55%   76.55%   +<.01%     
==========================================
  Files          93       93              
  Lines      136840   136841       +1     
==========================================
+ Hits       104756   104761       +5     
+ Misses      32084    32080       -4
Impacted Files Coverage Δ
src/if_xcmdsrv.c 84.53% <0%> (-0.18%) ⬇️
src/normal.c 74.35% <0%> (-0.08%) ⬇️
src/if_py_both.h 76.58% <0%> (ø) ⬆️
src/getchar.c 75.21% <0%> (+0.04%) ⬆️
src/gui_gtk_x11.c 48.08% <0%> (+0.04%) ⬆️
src/gui.c 49.58% <0%> (+0.05%) ⬆️
src/ex_cmds2.c 82.72% <0%> (+0.09%) ⬆️
src/os_unix.c 57.56% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd7155...cf8515b. Read the comment docs.

Bram Moolenaar

unread,
Jul 29, 2018, 8:24:37 AM7/29/18
to vim/vim, Subscribed

Closed #3263.

Bram Moolenaar

unread,
Jul 29, 2018, 8:24:37 AM7/29/18
to vim/vim, Subscribed

Thanks, I'll include it

h_east

unread,
Aug 8, 2018, 4:00:30 AM8/8/18
to vim/vim, Subscribed

Modeline of the following document still has no "noet".
Are there any reasons?

todo.txt
uganda.txt
undo.txt
usr_01.txt
usr_02.txt
usr_03.txt
usr_04.txt
usr_05.txt
usr_06.txt
usr_07.txt
usr_08.txt
usr_09.txt
usr_10.txt
usr_11.txt
usr_12.txt
usr_20.txt
usr_21.txt
usr_22.txt
usr_23.txt
usr_24.txt
usr_25.txt
usr_26.txt
usr_27.txt
usr_28.txt
usr_29.txt
usr_30.txt
usr_31.txt
usr_32.txt
usr_40.txt
usr_41.txt
usr_42.txt
usr_43.txt
usr_44.txt
usr_45.txt
usr_90.txt
usr_toc.txt
version4.txt
version5.txt
version6.txt
version7.txt
version8.txt
vi_diff.txt
visual.txt
windows.txt
workshop.txt

--
Best regards,
Hirohito Higashi (h_east)

h_east

unread,
Aug 8, 2018, 10:35:12 AM8/8/18
to vim_dev
Hi Bram and list,

2018-8-8(Wed) 17:00:30 UTC+9 h_east:

I attached patch.
Please check it out.

more_doc_add_noet.patch

Yee Cheng Chin

unread,
Aug 8, 2018, 12:50:58 PM8/8/18
to vim/vim, Subscribed

Um… because I missed them! I don't know how though. I will go through them again and submit another PR. Thanks for catching this.

Yee Cheng Chin

unread,
Aug 8, 2018, 12:54:36 PM8/8/18
to vim/vim, Subscribed

Actually, from casually browsing I think I probably screwed up in my regex replacement, and didn't double check I got all files.

K.Takata

unread,
Aug 8, 2018, 4:28:19 PM8/8/18
to vim/vim, Subscribed

@ychin h-east has already sent a patch: https://groups.google.com/d/msg/vim_dev/ztv-TlKh7ng/2MB4DKnzCAAJ

Bram Moolenaar

unread,
Aug 8, 2018, 5:08:36 PM8/8/18
to vim...@googlegroups.com, h_east

Hirohito Higashi wrote:

> 2018-8-8(Wed) 17:00:30 UTC+9 h_east:
> > Modeline of the following document still has no "noet".
>
> I attached patch.
> Please check it out.

I'll include it, thanks.

--
ARTHUR: Go on, Bors, chop its head off.
BORS: Right. Silly little bleeder. One rabbit stew coming up.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

h_east

unread,
Aug 8, 2018, 8:11:13 PM8/8/18
to vim/vim, Subscribed

Ah, I sent a patch via the vim_dev mailing list.
Normally, posting to the mailing list should also be reflected in GitHub's issue, but sometimes it is not done.

@k-takata Thank you for following this.

@ychin Do not mind 👍

Christian Brabandt

unread,
Aug 9, 2018, 5:11:36 AM8/9/18
to vim/vim, Subscribed

Normally, posting to the mailing list should also be reflected in GitHub's issue, but sometimes it is not done.

That works only if the mail is send back to the given Mail-Follow-To: Header which was this (shorten here to not allow spamming):

Mail-Followup-To: reply+[...]2cf00000001178265...@reply.github.com

As far as I can seen, the message was not sent there, so it was not mirrored back to github. In any case, attachments usually do not make it back to github, although I have seen them sometimes included as plain text bellow the message. Might depend on the Content-Type or similar email header. Did never investigate.

Reply all
Reply to author
Forward
0 new messages