ch_open no longer calls the defined callback when message number is 0

[Christian J. Robinson]

At some point in the last 12-24 hours a patch broke the functionality
of Vim handling messages with a message number of 0 and sending them
to the callback specified in the ch_open() call.

- Christian

--
"Progress isn't made by early risers. It's made by lazy men trying to find
easier ways to do something." -- Robert Heinlein
Christian J. Robinson <hep...@gmail.com> http://christianrobinson.name/

[Bram Moolenaar]

Christian J. Robinson wrote:

> At some point in the last 12-24 hours a patch broke the functionality
> of Vim handling messages with a message number of 0 and sending them
> to the callback specified in the ch_open() call.

We should have a test for that. It's in the todo list...

I think it's because the ch_block_id defaults to 0. Should probably
default to -1. Need the test to check that this fixes the problem.

So, do you have a nice simple way to check if this works?

--
hundred-and-one symptoms of being an internet addict:
213. Your kids start referring to you as "that guy in front of the monitor."

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Bram Moolenaar]

I wrote:

> Christian J. Robinson wrote:
>
> > At some point in the last 12-24 hours a patch broke the functionality
> > of Vim handling messages with a message number of 0 and sending them
> > to the callback specified in the ch_open() call.
>
> We should have a test for that. It's in the todo list...
>
> I think it's because the ch_block_id defaults to 0. Should probably
> default to -1. Need the test to check that this fixes the problem.
>
> So, do you have a nice simple way to check if this works?

I managed to write a test and fix the problem.

There are still more tests to be added, thus it's very well possible
there are a few more problems to be uncovered. It's helpful when you
find a problem that you have a script to reproduce it.

--
hundred-and-one symptoms of being an internet addict:

218. Your spouse hands you a gift wrapped magnet with your PC's name
on it and you accuse him or her of genocide.