[vim/vim] Test_writefile_fails_conversion failure on Solaris (#1872)
Danek Duvall
Testing recent versions of vim on Solaris, I get the following error:
From test_writefile.vim:
Found errors in Test_writefile_fails_conversion():
function RunTheTest[24]..Test_writefile_fails_conversion line 10: command did not fail: write ++enc=cp932
function RunTheTest[24]..Test_writefile_fails_conversion line 11: Expected ['line one', 'line two'] but got ['first line', 'cannot convert ?', 'third line']
The test was introduced in 8.0.0685 (e6bf655). From our i18n experts, it appears that Linux and Solaris took different paths when implementing the POSIX iconv spec; namely, that
the results of encountering invalid characters in the input stream (either those that are not characters in the codeset of the input file or that have no corresponding character in the codeset of the output file) shall be specified in the system documentation
Thus the assertions are based on bad assumptions.
I don't know the problem well enough to suggest a more universal test, or to judge whether the fix itself works on Solaris (though I'm guessing it doesn't). Solaris does support //REPLACE_HEX and //RESTORE_HEX modifiers to the arguments to iconv_open(), which might prove useful here, and I've confirmed that the string in the test does get converted to and from a lossless hex representation appropriately when converted using the commandline iconv tool.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
Bram Moolenaar
Danek Duvall wrote:
> Testing recent versions of vim on Solaris, I get the following error:
>
> ```
> >From test_writefile.vim:
> Found errors in Test_writefile_fails_conversion():
> function RunTheTest[24]..Test_writefile_fails_conversion line 10: command did not fail: write ++enc=cp932
> function RunTheTest[24]..Test_writefile_fails_conversion line 11: Expected ['line one', 'line two'] but got ['first line', 'cannot convert ?', 'third line']
> ```
>
>
> > the results of encountering invalid characters in the input stream (either those that are not characters in the codeset of the input file or that have no corresponding character in the codeset of the output file) shall be specified in the system documentation
>
> Thus the assertions are based on bad assumptions.
>
Perhaps we can first use the iconv() function to check whether the
conversion fails. With your Vim, try this:
echo iconv("cannot convert \u010b", 'utf-8', 'cp932')
I get "cannot convert ?".
--
hundred-and-one symptoms of being an internet addict:
237. You tattoo your email address on your forehead.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Danek Duvall
I get the same message.
Bram Moolenaar
> I get the same message.
What doest "uname" return?
Or perhaps this is a SysV common issue?
--
hundred-and-one symptoms of being an internet addict:
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Pavel Heimlich
On Solaris 'uname' returns:
SunOS
I don't have any other Unices around.
Danek Duvall
I've confirmed that this happens on 11.3 as well as the development builds of the next release. I don't have easy access to older versions.
It's easy enough to skip the test on Solaris, but I'd rather have a functioning test. I'm just not sure how to write one. And I suspect that the functionality is broken (on Solaris, or any OS with a similar iconv behavior) as well.
Bram Moolenaar
Pavel Heimlich wrote:
> On Solaris 'uname' returns:
> SunOS
>
> I don't have any other Unices around.
"SunOS".
--
PRINCE: He's come to rescue me, father.
LAUNCELOT: (embarrassed) Well, let's not jump to conclusions ...
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Bram Moolenaar
Danek Duvall wrote:
> I've confirmed that this happens on 11.3 as well as the development
> builds of the next release. I don't have easy access to older
> versions.
>
> It's easy enough to skip the test on Solaris, but I'd rather have a
> functioning test. I'm just not sure how to write one. And I suspect
> that the functionality is broken (on Solaris, or any OS with a similar
> iconv behavior) as well.
In this situation the conversion does not fail. It's difficult to check
that.
--
A vacation is a period of travel during which you find that you
took twice as many clothes and half as much money as you needed.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
lacygoill
Fixed by 8.1.0347
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Christian Brabandt
Closed #1872.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.