Patch 7.3.710

51 views
Skip to first unread message

Bram Moolenaar

unread,
Oct 22, 2012, 11:09:12 PM10/22/12
to vim...@googlegroups.com

Patch 7.3.710 (after 7.3.704)
Problem: Patch 7.3.704 breaks "fn".
Solution: Add check for ca.cmdchar. (Christian Brabandt)
Files: src/normal.c


*** ../vim-7.3.709/src/normal.c 2012-10-21 03:54:27.000000000 +0200
--- src/normal.c 2012-10-23 05:02:27.000000000 +0200
***************
*** 1086,1092 ****
ca.nchar = ca.extra_char;
idx = find_command(ca.cmdchar);
}
! else if (ca.nchar == 'n' || ca.nchar == 'N')
ca.oap->op_type = get_op_type(*cp, NUL);
else if (*cp == Ctrl_BSL)
{
--- 1086,1092 ----
ca.nchar = ca.extra_char;
idx = find_command(ca.cmdchar);
}
! else if ((ca.nchar == 'n' || ca.nchar == 'N') && ca.cmdchar == 'g')
ca.oap->op_type = get_op_type(*cp, NUL);
else if (*cp == Ctrl_BSL)
{
*** ../vim-7.3.709/src/version.c 2012-10-21 23:55:59.000000000 +0200
--- src/version.c 2012-10-23 04:59:21.000000000 +0200
***************
*** 727,728 ****
--- 727,730 ----
{ /* Add new patch number below this line */
+ /**/
+ 710,
/**/

--
The budget process was invented by an alien race of sadistic beings who
resemble large cats.
(Scott Adams - The Dilbert principle)

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Andy Wokula

unread,
Nov 13, 2012, 4:02:14 PM11/13/12
to vim...@googlegroups.com
Am 23.10.2012 05:09, schrieb Bram Moolenaar:
>
> Patch 7.3.710 (after 7.3.704)
> Problem: Patch 7.3.704 breaks "fn".
> Solution: Add check for ca.cmdchar. (Christian Brabandt)
> Files: src/normal.c

Still doesn't look right (gVim 7.3.712).

When typing fn the cursor changes its shape.
Typing fnl jumps to begin of buffer.

Also the r command is affected:
Bothrn and rN beep.

--
Andy

Christian Brabandt

unread,
Nov 14, 2012, 1:23:30 AM11/14/12
to vim...@googlegroups.com
Hm, I don't see this behaviour with vim 7.3.712 on Unix but only with
the latest Cream version which is 7.3.709 on Windows (don't have a
built machine for Windows)

regards,
Christian

Tony Mechelynck

unread,
Nov 14, 2012, 1:59:19 AM11/14/12
to vim...@googlegroups.com, Andy Wokula
On 13/11/12 22:02, Andy Wokula wrote:
> Am 23.10.2012 05:09, schrieb Bram Moolenaar:
>>
>> Patch 7.3.710 (after 7.3.704)
>> Problem: Patch 7.3.704 breaks "fn".
>> Solution: Add check for ca.cmdchar. (Christian Brabandt)
>> Files: src/normal.c
>
> Still doesn't look right (gVim 7.3.712).

Are you sure patch 7.3.710 is included? (Check near the top of the
output of :version - it is possible to include one patch without the
preceding one).

>
> When typing fn the cursor changes its shape.
> Typing fnl jumps to begin of buffer.
>
> Also the r command is affected:
> Bothrn and rN beep.
>

Here, rn and rN only beep if I try to modify a file where 'nomodifiable'
is set, for instance a helpfile. In that case I get:

E21: Cannot make changes, 'modifiable' is off

In an "ordinary" file the replace proceeds normally (but with a message
the first time if the file is 'readonly').


VIM - Vi IMproved 7.3 (2010 Aug 15, compiled Oct 23 2012 05:40:32)
Included patches: 1-712
Compiled by antoine.m...@gmail.com
Huge version with GTK2-GNOME GUI. Features included (+) or not (-):
[...]


Best regards,
Tony.
--
I think we can all agree that there is not enough common courtesy shown
... HEY! PAY ATTENTION WHEN I'M TALKING TO YOU DAMMIT! I said I think
we can all agree that there is not enough common courtesy shown today.
When we take the time to be courteous to each other, we find that we
are happier and less likely to engage in nuclear war. This point was
driven home by the recent summit talks, where Nancy Reagan and Raisa
Gorbachev, each of whose husband thinks the other's husband is vermin,
were able to sit down at a high-level tea and engage in courteous
conversation ...
-- Dave Barry, "The Stuff of Etiquette"

Andy Wokula

unread,
Nov 14, 2012, 3:50:56 AM11/14/12
to vim...@googlegroups.com
Ok, my mistake then (using Mercurial). Sorry for the noise.

--
Andy
Reply all
Reply to author
Forward
0 new messages