[vim/vim] options: improve copying of buffer-local value of window option (#2336)

29 views
Skip to first unread message

Björn Linse

unread,
Nov 14, 2017, 5:01:49 AM11/14/17
to vim/vim, Subscribed

Before this change, only a value is copied from another window if the buffer
is not current in that window. With this change, it is also copied
from a window, in which the buffer is currently displayed.

Previous discussion: neovim/neovim#7551

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/2336

Commit Summary

  • options: improve copying of buffer-local value of window option

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

Björn Linse

unread,
Nov 16, 2017, 7:35:40 AM11/16/17
to vim/vim, Push

@bfredl pushed 1 commit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Codecov

unread,
Nov 16, 2017, 8:17:57 AM11/16/17
to vim/vim, Subscribed

Codecov Report

Merging #2336 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2336      +/-   ##
==========================================
- Coverage   74.46%   74.42%   -0.05%     
==========================================
  Files          90       90              
  Lines      132167   132176       +9     
  Branches    29025    30742    +1717     
==========================================
- Hits        98421    98371      -50     
- Misses      33721    33776      +55     
- Partials       25       29       +4
Impacted Files Coverage Δ
src/buffer.c 77.01% <100%> (+0.09%) ⬆️
src/gui_beval.c 39.87% <0%> (-4.91%) ⬇️
src/libvterm/src/state.c 40.38% <0%> (-1.02%) ⬇️
src/window.c 80.86% <0%> (-0.53%) ⬇️
src/message.c 68.06% <0%> (-0.2%) ⬇️
src/terminal.c 65.01% <0%> (-0.18%) ⬇️
src/term.c 50.72% <0%> (-0.17%) ⬇️
src/if_py_both.h 76.45% <0%> (-0.15%) ⬇️
src/gui_gtk_x11.c 47.6% <0%> (-0.1%) ⬇️
src/channel.c 82.44% <0%> (-0.05%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2392143...a4c911c. Read the comment docs.

Björn Linse

unread,
Nov 16, 2017, 3:48:07 PM11/16/17
to vim/vim, Subscribed

Tests are passing now after adding missing NULL check.

Bram Moolenaar

unread,
May 13, 2018, 12:06:11 PM5/13/18
to vim/vim, Subscribed

Closed #2336 via 25782a7.

Reply all
Reply to author
Forward
0 new messages