[vim/vim] Fix russian-jcukenwintype.vim to actually much the Cyrillic jcuken windows typewriter keymap (#1656)

[Von Random]

Cyrillic jcuken windows typewriter mappings are a bit off. Besides not actually providing some of the windows typewriter mappings this keymap is also missing few digits (and, thus, is actually almost unusable without numpad), the order of symbol definition was a bit wrong and comment also needed a fix.

I believe the intention of the original author was to have special symbols mapped in upper register the same way as in default winkeys, but in such case the keymap name is misleading.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/1656

Commit Summary

• Fix russian-jcukenwintype.vim to actually much the jcuken windows typewriter keymap. Fix comment as well.

File Changes

• M runtime/keymap/russian-jcukenwintype.vim (30)

Patch Links:

• https://github.com/vim/vim/pull/1656.patch
• https://github.com/vim/vim/pull/1656.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

[Von Random]

As per contributing recommendation, I've tried contacting the file maintainer via email first, but haven't received any reply.

[Codecov]

Codecov Report

Merging #1656 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1656      +/-   ##
==========================================
- Coverage   74.87%   74.87%   -0.01%     
==========================================
  Files          76       76              
  Lines      124888   124848      -40     
==========================================
- Hits        93516    93476      -40     
  Misses      31372    31372

Impacted Files	Coverage Δ
src/if_py_both.h	75.56% <0%> (-0.47%)	⬇️
src/channel.c	83.6% <0%> (-0.19%)	⬇️
src/term.c	53.37% <0%> (-0.06%)	⬇️
src/gui.c	45.5% <0%> (-0.06%)	⬇️
src/window.c	81.08% <0%> (-0.04%)	⬇️
src/message.c	68.52% <0%> (+0.45%)	⬆️
src/version.c	80.3% <0%> (+1.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7637c4...5abaa68. Read the comment docs.

[Bram Moolenaar]

Can someone confirm this is a good change to include?

[Von Random]

It can be tested against setxkbmap -layout ru -variant typewriter. Just keep a way to run setxkbmap -layout us after you're done. ;)