[vim/vim] buffer name should be [Terminal] (#1869)

30 views
Skip to first unread message

mattn

unread,
Jul 23, 2017, 10:24:46 PM7/23/17
to vim/vim, Subscribed

I prefer [Terminal]


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/1869

Commit Summary

  • buffer name should be [Terminal]

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

Bram Moolenaar

unread,
Jul 24, 2017, 3:45:17 PM7/24/17
to vim/vim, Subscribed

Closed #1869 via 2155441.

Bram Moolenaar

unread,
Jul 24, 2017, 3:45:27 PM7/24/17
to vim/vim, Subscribed

Yasuhiro Matsumoto wrote:

> I prefer [Terminal]

I was planning to put the title there, the one that the programs sets on
the terminal. Hmm, looks a bit strange with the buffer name in the Vim
window title and the vterm title in the status. Better make them the
same, as what happens with a buffer name. It is also useful to put
"running" or "finished" there. I'll make that work.

--
Get a life? What is the URL where it can be downloaded?

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Nikolai Aleksandrovich Pavlov

unread,
Jul 24, 2017, 4:19:40 PM7/24/17
to vim/vim, Subscribed

Why not what Neovim does, i.e. use term:// pseudo-protocol to describe how (using which command) terminal was created? The main issue with names like [Terminal] is that you can’t save terminals with :mksession.

Bram Moolenaar

unread,
Jul 24, 2017, 5:06:19 PM7/24/17
to vim/vim, Subscribed

Nikolai Pavlov wrote:

> Why not what Neovim does, i.e. use `term://` pseudo-protocol to
> describe how (using which command) terminal was created? The main
> issue with names like `[Terminal]` is that you can’t save terminals
> with `:mksession`.

I already added a todo item to deal with viminfo. Not sure yet what to
do there (having a command re-started because it happens to be running
in a terminal seems a bit unexpected).

But for the displayed text showing term:// is definitely weird.
Normally the command itself is enough to know it's a terminal.

--
hundred-and-one symptoms of being an internet addict:
236. You start saving URL's in your digital watch.


/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

Reply all
Reply to author
Forward
0 new messages