[Patch] Visual mode movements for python.vim

[Carlos Pita]

Hi all,

I've patched the python.vim ftplugin in order it to support [[,]],]m,[m movements in visual mode also. The patch simplifies the logic of the previous implementation by using the search() function instead of user-oriented commands.

There are a couple of minor improvements also:

* Explicitly check executable('pydoc') == 1 (to avoid the -1 trap).
* Expand a couple of tabs to spaces to normalize indentation a bit.

Hope you find it useful. I tried to contact the maintainer before but to no avail so I'm submitting this directly to this list.

Cheers
--
Carlos

[Carlos Pita]

PS: maybe worth noticing, the new implementation also fixes a
potential bug related to the approach to get the v:count argument the
previous implementation adopts: it defines a range function, but then
the argument must be valid as a range not just as a count. In practice
this shouldn't be a problem, but it's not entirely correct. Moreover,
it is a problem for implementing the visual mode map. All in all I
feel the new approach is cleaner.

[Carlos Pita]

Here is an updated patch with a couple of improvements:

1. Reach BOF/EOF when there are no more class/method text objects remaining.

2. In visual mode select the object up to its beginning/end without matching the first line/char of the next object (I think it's not difficult to implement the omap version from here, but I don't have the time to do it right now).

Cheers
--
Carlos

[Bram Moolenaar]

Perhaps you would like to take over maintenance of this file?


--
"Never be afraid to tell the world who you are."
-- Anonymous

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

[Carlos Pita]

> Perhaps you would like to take over maintenance of this file?

I would be glad to.

Cheers
--
Carlos

[Carlos Pita]

Updated patch with a couple of text objects (]] and ]m) defined on top of my previous n and v maps.

Regarding the maintenance I know nothing about the formalities yet but I promise to get informed ASAP.

Cheers
--
Carlos

[Bram Moolenaar]

The complicated part of maintaining a runtime file is making it work
better. You already did that. The easy part is updating the header to
announce you as the maintainer, moving the original maintainer to
another line.

It does mean that others may send you suggestions for improvement or
complain about something that doesn't work. Ideally you take care of
that.

And whenever you make improvements, mail me the new file.


--
Overflow on /dev/null, please empty the bit bucket.