[vim/vim] New & improved Pike syntax colouring. (#2558)

Stephen R. van den Berg

unread,

Jan 16, 2018, 7:25:00 AM1/16/18

to vim/vim, Subscribed

This is a long overdue update of the Pike language syntax colouring support.

It now supports Pike 8.1, embedded SQL, embedded Autodoc and numerous other fixes.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/2558

Commit Summary

New & improved Pike syntax colouring.

File Changes

A runtime/syntax/autodoc.vim (70)
M runtime/syntax/pike.vim (396)

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

Stephen R. van den Berg

unread,

Jan 16, 2018, 4:42:55 PM1/16/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

fd73e56 pike.vim: Improve preprocessor formatting (more detail).

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 17, 2018, 8:11:25 AM1/17/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

829179d Autodoc enhanced with error highlights.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 18, 2018, 3:43:22 AM1/18/18

to vim/vim, Subscribed

I presume that I can ignore the two automated and failed coverage/coveralls and continuous-integration/travis-ci/pr checks?

Stephen R. van den Berg

unread,

Jan 18, 2018, 4:24:17 AM1/18/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

4d49f18 Add support for Cmod files (used in Pike development).

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

K.Takata

unread,

Jan 18, 2018, 4:27:19 AM1/18/18

to vim/vim, Subscribed

@k-takata commented on this pull request.

In runtime/syntax/pike.vim:

> @@ -1,142 +1,385 @@
 " Vim syntax file
 " Language:	Pike
-" Maintainer:	Francesco Chemolli <kin...@kame.usr.dsi.unimi.it>

Could you change this line to "Previous Maintainer:" instead of removing?

Stephen R. van den Berg

unread,

Jan 18, 2018, 4:29:51 AM1/18/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

64186a7 Include proper version and remarks.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 18, 2018, 4:31:13 AM1/18/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

06bb070 Added previous maintainer.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 18, 2018, 4:34:43 AM1/18/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

709dc71 Removed some unused colours.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 18, 2018, 4:35:52 AM1/18/18

to vim/vim, Subscribed

@BuGlessRB commented on this pull request.

In runtime/syntax/pike.vim:

> @@ -1,142 +1,385 @@
 " Vim syntax file
 " Language:	Pike
-" Maintainer:	Francesco Chemolli <kin...@kame.usr.dsi.unimi.it>

Fixed.

Stephen R. van den Berg

unread,

Jan 18, 2018, 5:01:06 AM1/18/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

7640118 Workaround for but in matchit.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 18, 2018, 7:12:50 AM1/18/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

953b59c Added a lot of predefined functions.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 18, 2018, 8:01:30 AM1/18/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

4753b1e Avoid triggering embedded autodoc on every exclamation mark.

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 18, 2018, 8:26:46 AM1/18/18

to vim/vim, Push

@BuGlessRB pushed 1 commit.

05c879e Support Pike filetype deduction from #./akimportnew.pike fast 2018-01-01

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

Stephen R. van den Berg

unread,

Jan 18, 2018, 8:40:03 AM1/18/18

to vim/vim, Subscribed

I folded all commits into a single commit for easy reviewing.

Stephen R. van den Berg

unread,

Jan 19, 2018, 8:03:30 PM1/19/18

to vim/vim, Subscribed

There's two commits now:

Updates pike.vim, adds support for cmod.vim and autodoc.vim.
Updates c.vim to add optional support for embedded Autodoc.

Stephen R. van den Berg

unread,

Jan 20, 2018, 3:53:43 AM1/20/18

to vim/vim, Subscribed

For reviewing use the following link: #2558
Due to the rebase/forced push, the older links might not work anymore.

Stephen R. van den Berg

unread,

Jan 22, 2018, 4:54:36 AM1/22/18

to vim/vim, Subscribed

Adjusted the unit tests for the mapping of lpc/ulpc and cmod filetypes.

Stephen R. van den Berg

unread,

Jan 25, 2018, 3:18:46 AM1/25/18

to vim/vim, Subscribed

Is there anything I can do to expedite the review and get these changes committed to the main repository?

Bram Moolenaar

unread,

Jan 28, 2018, 8:04:58 AM1/28/18

to vim/vim, Subscribed

I'll include it, thanks.
It would be nice to document the variables in the help.

Bram Moolenaar

unread,

Jan 28, 2018, 8:05:00 AM1/28/18

to vim/vim, Subscribed

Closed #2558.

Reply all

Reply to author

Forward