[vim/vim] Fixed several issues with Test_profile (#1384)

[Dominique Pellé]

• Test_profile was unexpected slow, -es Vim option makes it much faster
• using count instead of l:count caused error in script profiled by Test_profile_func
• check for v:shell_error after running system
• tentatively re-enable tests for Windows as above fixes presumably explain
  while test failed on Windows.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/1384

Commit Summary

• Fixed several issues with Test_profile

File Changes

• M src/testdir/test_profile.vim (68)

Patch Links:

• https://github.com/vim/vim/pull/1384.patch
• https://github.com/vim/vim/pull/1384.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

[Dominique Pellé]

Sadly, tests still fails on Windows in Appveyor.
They succeed on all other platforms in Travis.
Here is the error on Appveyor:

From test_profile.vim:
Found errors in Test_profile_file():
function RunTheTest[13]..Test_profile_file line 19: Expected 0 but got 1
Caught exception in Test_profile_file(): Vim(let):E484: Can't open file Xprofile_file.log @ function RunTheTest[13]..Test_profile_file, line 21
Found errors in Test_profile_func():
function RunTheTest[13]..Test_profile_func line 35: Expected 0 but got 1
Caught exception in Test_profile_func(): Vim(let):E484: Can't open file Xprofile_func.log @ function RunTheTest[13]..Test_profile_func, line 37
TEST FAILURE 
NMAKE : fatal error U1077: 'if' : return code '0x1'
Stop.
Command exited with code 2

I don't understand why, and I have no Windows machine to debug.
Perhaps it's the same reason why Test_system_exmode() in testdir/test_system.vim
is disabled, as it uses system() in a similar way as test_profile.vim.

Until this is fixed, I'll disable the profiling tests for Windows.

[Dominique Pellé]

@dpelle pushed 1 commit.

• c5f89eb Disable test on Windows: system(...) fails somehow

—
You are receiving this because you are subscribed to this thread.

View it on GitHub

[mossg...@yahoo.com]

--------------------------------------------
On Sun, 1/15/17, Dominique Pellé <vim-dev...@256bit.org> wrote:

Subject: Re: [vim/vim] Fixed several issues with Test_profile (#1384)
To: "vim/vim" <v...@noreply.github.com>
Cc: "Push" <pu...@noreply.github.com>
Date: Sunday, January 15, 2017, 11:30 PM

--

--

You received this message from the "vim_dev"
maillist.

Do not top-post! Type your reply below the text you are
replying to.

For more information, visit http://www.vim.org/maillist.php



---

You received this message because you are subscribed to the
Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails
from it, send an email to vim_dev+u...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.
omania in relatiile politice internationale in anii premergatori declansarii celui de-al doilea razboi mondial 1936-1939. Datorita complexitatii situatiei politice internationale Romania si-a aratat dorinta de a mentine in continuare relatii de buna vecinatate cu U.R.S.S. dar in paralel a initiat normalizarea raporturilor sale cu Germania. Gheorghe Bratianu cunoscutul istoric si om politic va deschide seria contactelor cu AdolfHitler la 16 noiembrie 1936.

[Dominique Pellé]

Closed #1384.