[vim/vim] Compile with explicitly specified path first (#1100)

38 views
Skip to first unread message

Yousong Zhou

unread,
Sep 19, 2016, 3:44:53 AM9/19/16
to vim/vim
Problem:    Wrong header and library files from system directory may be
            used instead of the ones specified on configure command line
Solution:   Compile with XXX_FLAGS appearing before ALL_CFLAGS

I came across the issue firstly with lua support when I try to have my own build of vim and its dependencies (https://github.com/yousong/build-scripts/blob/master/build-vim.sh).


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/1100

Commit Summary

  • Compile with explicitly specified path first

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

nuko8

unread,
Sep 19, 2016, 4:38:58 AM9/19/16
to vim/vim

Just to make sure. Does $(call variable, param, param,…) work with make(1) other than GNU make?

Yousong Zhou

unread,
Sep 19, 2016, 5:09:42 AM9/19/16
to vim/vim

Other choices would be

  1. Prepending those LUA_CFLAGS, PERL_CFLAGS, etc. to ALL_CFLAGS
  2. Expand manually the $(call CCC,xxx) to eliminate possible compatibility issues altoghter

Personally I prefer the first choice.

Yousong Zhou

unread,
Sep 19, 2016, 5:22:29 AM9/19/16
to vim/vim

Changes v1 -> v2

  • Avoid using $(call CCC,xxx)
  • Expand the change to include targets missed out in previous version

Yousong Zhou

unread,
Dec 10, 2016, 12:14:24 AM12/10/16
to vim/vim

Hi, @brammool , 3 monthes have passed, any thoughts on this one?

ouidac...@yahoo.com

unread,
Dec 10, 2016, 8:13:40 PM12/10/16
to vim...@googlegroups.com

--------------------------------------------
On Sat, 12/10/16, Yousong Zhou <vim-dev...@256bit.org> wrote:

Subject: Re: [vim/vim] Compile with explicitly specified path first (#1100)
To: "vim/vim" <v...@noreply.github.com>
Date: Saturday, December 10, 2016, 7:14 AM
--

--

You received this message from the "vim_dev"
maillist.

Do not top-post! Type your reply below the text you are
replying to.

For more information, visit http://www.vim.org/maillist.php



---

You received this message because you are subscribed to the
Google Groups "vim_dev" group.

To unsubscribe from this group and stop receiving emails
from it, send an email to vim_dev+u...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.
08Initiativa cea mai insemnata a autoritatilor provizorii de la Bucuresti este insa aceea privind plebiscitul pentru alegerea ca domn al Romaniei a printului Caro de Hohenzollern - Sigmaringen.

Bram Moolenaar

unread,
Jan 17, 2017, 1:20:55 PM1/17/17
to vim/vim, Subscribed

Closed #1100 via 6e78e27.

Reply all
Reply to author
Forward
0 new messages