[vim/vim] runtime/syntax/gitconfig.vim: do not change iskeyword (#2814)

32 views
Skip to first unread message

Daniel Hahler

unread,
Apr 17, 2018, 4:52:17 PM4/17/18
to vim/vim, Subscribed

Ref: #2810 (comment)

/cc @tpope (assuming that you prefer this over git-send-email)


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/2814

Commit Summary

  • runtime/syntax/gitconfig.vim: do not change iskeyword

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

Tim Pope

unread,
Apr 17, 2018, 5:04:19 PM4/17/18
to vim/vim, Subscribed

Digits should be allowed.

Daniel Hahler

unread,
Apr 17, 2018, 5:09:53 PM4/17/18
to vim/vim, Subscribed

Thanks, amended.

Codecov

unread,
Apr 17, 2018, 5:10:45 PM4/17/18
to vim/vim, Subscribed

Codecov Report

Merging #2814 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
+ Coverage   75.42%   75.43%   +<.01%     
==========================================
  Files          92       92              
  Lines      134583   134583              
==========================================
+ Hits       101513   101517       +4     
+ Misses      33070    33066       -4
Impacted Files Coverage Δ
src/if_xcmdsrv.c 84.35% <0%> (-0.36%) ⬇️
src/ex_cmds.c 79.46% <0%> (-0.23%) ⬇️
src/os_unix.c 54.96% <0%> (-0.14%) ⬇️
src/gui_gtk_x11.c 47.68% <0%> (-0.1%) ⬇️
src/undo.c 82.51% <0%> (-0.07%) ⬇️
src/gui.c 47.78% <0%> (-0.06%) ⬇️
src/channel.c 83.13% <0%> (+0.08%) ⬆️
src/ex_cmds2.c 78.66% <0%> (+0.09%) ⬆️
src/term.c 60.57% <0%> (+0.15%) ⬆️
src/window.c 81.99% <0%> (+0.16%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e87edf3...6e19040. Read the comment docs.

Christian Brabandt

unread,
Apr 18, 2018, 1:39:56 AM4/18/18
to vim/vim, Subscribed

Alternatively, instead of using :setlocal iskeyword you can use :syntax iskeyword. That has been added specifically for changing the 'iskeyword' setting only for the syntax files without affecting other things in Vim. That means you would not have to change your syntax regular expressions. See :h :syn-iskeyword

Christian Brabandt

unread,
May 18, 2018, 2:43:30 AM5/18/18
to vim/vim, Subscribed

I think this has been merged by the upstream @tpope
So I am closing this.

@tpope you might want to send an updated version to Bram for distribution with Vim 8.1

Christian Brabandt

unread,
May 18, 2018, 2:43:31 AM5/18/18
to vim/vim, Subscribed

Closed #2814.

Tim Pope

unread,
May 18, 2018, 1:58:08 PM5/18/18
to vim/vim, Subscribed

Unfortunately Vim 8.1 already dropped before your comment. I'll aim to avoid waiting till the last minute with Vim 8.2.

Christian Brabandt

unread,
May 19, 2018, 1:37:52 PM5/19/18
to vim/vim, Subscribed

Unfortunately Vim 8.1 already dropped before your comment. I'll aim to avoid waiting till the last minute with Vim 8.2.

@tpope You can always send updates to Bram whenever you think they should be included. Bram updates runtime files every once in a while and not just before a release.

Reply all
Reply to author
Forward
0 new messages