[vim/vim] Only spell-check comments and strings in Inno Setup files (#2739)

33 views
Skip to first unread message

VZ

unread,
Mar 21, 2018, 5:54:57 PM3/21/18
to vim/vim, Subscribed

Use @Spell to avoid spell-checking Inno Setup directives and file names,
to avoid showing many spelling errors for any .iss file.

Note: I tried contacting Jason Mills whose email is mentioned in the comment in the beginning of this file, as recommended by the contributors guidelines, but this email doesn't work any longer, so I'm submitting it here.

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/2739

Commit Summary

  • Only spell-check comments and strings in Inno Setup files

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

Codecov

unread,
Mar 21, 2018, 6:50:23 PM3/21/18
to vim/vim, Subscribed

Codecov Report

Merging #2739 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
+ Coverage      75%      75%   +<.01%     
==========================================
  Files          92       92              
  Lines      134149   134149              
==========================================
+ Hits       100614   100621       +7     
+ Misses      33535    33528       -7
Impacted Files Coverage Δ
src/version.c 80.8% <0%> (-1.02%) ⬇️
src/gui.c 47.68% <0%> (-0.11%) ⬇️
src/terminal.c 56.72% <0%> (-0.05%) ⬇️
src/misc1.c 84.41% <0%> (+0.06%) ⬆️
src/gui_gtk_x11.c 47.78% <0%> (+0.09%) ⬆️
src/os_unix.c 54.61% <0%> (+0.13%) ⬆️
src/term.c 60.37% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b571c63...9b39005. Read the comment docs.

Bram Moolenaar

unread,
Mar 22, 2018, 4:49:33 PM3/22/18
to vim/vim, Subscribed

> Use @Spell to avoid spell-checking Inno Setup directives and file names,
> to avoid showing many spelling errors for any .iss file.
>
> Note: I tried contacting Jason Mills whose email is mentioned in the
> comment in the beginning of this file, as recommended by the
> contributors guidelines, but this email doesn't work any longer, so
> I'm submitting it here.

Try this address for Jason: mills...@gmail.com


--
Latest survey shows that 3 out of 4 people make up 75% of the
world's population.

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///

VZ

unread,
Mar 22, 2018, 6:01:24 PM3/22/18
to vim/vim, Subscribed

Thanks, I've sent the patch to Jason at the new address and, at the very least, the email was accepted.

jase413

unread,
Jun 27, 2019, 1:26:13 PM6/27/19
to vim/vim, Subscribed

I see no issue with accepting this PR and merging it into the master.

Bram Moolenaar

unread,
Sep 27, 2019, 8:49:31 AM9/27/19
to vim/vim, Subscribed

I'll include the patch now.

Bram Moolenaar

unread,
Sep 27, 2019, 8:49:34 AM9/27/19
to vim/vim, Subscribed

Closed #2739.

Reply all
Reply to author
Forward
0 new messages