[vim/vim] travis: Explicitly use asan_symbolize to demangle ASAN logs (#2344)
James McCoy
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/2344
Commit Summary
- travis: Explicitly use asan_symbolize to demangle ASAN logs
File Changes
- M .travis.yml (2)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
James McCoy
Ok, this should be good now. https://travis-ci.org/vim/vim/builds/303596184 is a log showing the ASAN stack traces from a forced use-after-free I added for testing.
The problem was that Travis automatically includes a recent version of clang on its own, independent of Ubuntu's clang packaging. The install they provide doesn't have asan_symbolize or llvm-symbolize in a typical location, so I updated the Travis config to also install Ubuntu's clang package. This ensures we have asan_symbolize to run.
Since asan_symbolize is being used, we can also remove the attempted inclusion of llvm-symbolize's location into PATH.
Codecov
Codecov Report
Merging #2344 into master will decrease coverage by
<.01%.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #2344 +/- ## ========================================== - Coverage 74.33% 74.32% -0.01% ========================================== Files 90 90 Lines 132199 132200 +1 Branches 29031 29031 ========================================== - Hits 98270 98259 -11 - Misses 33900 33911 +11 - Partials 29 30 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/if_xcmdsrv.c | 84.71% <0%> (-0.54%) |
⬇️ |
| src/gui_beval.c | 44.47% <0%> (-0.31%) |
⬇️ |
| src/message.c | 68.06% <0%> (-0.2%) |
⬇️ |
| src/term.c | 50.64% <0%> (-0.17%) |
⬇️ |
| src/os_unix.c | 53.5% <0%> (-0.14%) |
⬇️ |
| src/gui_gtk_x11.c | 47.65% <0%> (-0.1%) |
⬇️ |
| src/window.c | 81.32% <0%> (-0.07%) |
⬇️ |
| src/if_py_both.h | 76.43% <0%> (-0.03%) |
⬇️ |
| src/channel.c | 82.44% <0%> (+0.04%) |
⬆️ |
| src/eval.c | 80.84% <0%> (+0.04%) |
⬆️ |
| ... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 7567d0b...555fb60. Read the comment docs.
Bram Moolenaar
Wonderful, thank you.