vertx-shell unregister built-in commands?

[Grant Haywood]

when using vertx-shell, I have a small groovy block that goes like this:

def reg = CommandRegistry.getShared(vertx)

["echo","sleep","cd","pwd","ls"].each{ String cmd ->

reg.unregisterCommand(cmd)

}


however I still see the commands in the shell, Is unregistering commands supported?

% help                                                                                                                  

available commands:                                                                                                     

echo                                                                                                                    

sleep                                                                                                                   

help                                                                                                                    

cd                                                                                                                      

pwd                                                                                                                     

ls                                                                                                                      

net-ls                                                                                                                  

local-map-get                                                                                                           

local-map-put                                                                                                           

local-map-rm                                                                                                            

bus-publish                                                                                                             

bus-send                                                                                                                

bus-tail                                                                                                                

verticle-ls                                                                                                             

verticle-deploy                                                                                                         

verticle-undeploy                                                                                                       

verticle-factories                                                                                                      

setup                                                                                                                   

component                                                                                                               

exit                                                                                                                    

logout                                                                                                                  

jobs                                                                                                                    

fg                                                                                                                      

bg          

[Julien Viet]

can you try with the unregisterCommand version that has an Handler<AsyncResult<Void>> to see if an error happens or not ?

--
You received this message because you are subscribed to the Google Groups "vert.x" group.
To unsubscribe from this group and stop receiving emails from it, send an email to vertx+un...@googlegroups.com.
Visit this group at https://groups.google.com/group/vertx.
To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/1b4bd19a-0a0e-4070-b107-582050471b8c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Grant Haywood]

Thanks for the reply

now my groovy block looks like this:

        ["echo", "sleep", "cd", "pwd", "ls"].each { String cmd ->

            reg.unregisterCommand(cmd, { AsyncResult res ->
                if(res.failed())
                    logger.error(res.cause())
            })
        }

and the relevant output looks like:

io.vertx.core.impl.NoStackTraceThrowable: Command echo not registered
io.vertx.core.impl.NoStackTraceThrowable: Command sleep not registered
io.vertx.core.impl.NoStackTraceThrowable: Command cd not registered
io.vertx.core.impl.NoStackTraceThrowable: Command pwd not registered
io.vertx.core.impl.NoStackTraceThrowable: Command ls not registered

[Julien Viet]

can you share the entire code, i.e how you create the shell and its connectors

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/5ee7ce62-4654-4135-828e-f57534326c3e%40googlegroups.com.

[Grant Haywood]

the example comes from
https://github.com/cinterloper/cintershell/blob/master/src/main/groovy/cintershellExample.groovy#L71

shadowJar should produce an executable jar that runs that file

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/5F312651-A94B-4E10-A153-68EF1933BF8A%40julienviet.com.

[Julien Viet]

Hi Grant,

this happens because the ShellService adds the BaseCommandPack to the underlying ShellServer separately, so the BaseCommandPack and the CommandRegistry are both added in the ShellServer using the registerCommandResolver().

in your case if you want to fine grained control what goes in your server, you need to build rather a ShellServer and start it instead of using the ShellService, for example:

CommandRegistry register = ….; // Create appropriate command registry

ShellServer server = ShellServer.create(vertx, shellServerOptions);

server.registerTermServer(new TelnetTermServer(vertx, telnetOptions));

server.registerCommandResolver(commandRegistry);

server.listen();

cheers

Julien

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/CAPayrd6zY9_1U1SC0px6bCNGQGT6ZTitUD8K2f4kouzQbf2PxA%40mail.gmail.com.

[Grant Haywood]

oh interesting, thank you for the tip!

I have another question, if you dont mind, is there any way to get the user name that authenticated (via properties or ldap or similar) from the CommandProcess  or Session  inside a command?

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/7ADC0DEB-86C7-44C8-A28D-60E38258D4E0%40julienviet.com.

[Julien Viet]

I think it should be added to the to the Session interface.

do you mind contribute this feature ?

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/CAPayrd4U%2B7jXyDm4fbxnDSTzo9a6MekLZjws0yYgOsRTzkiOTg%40mail.gmail.com.

[Grant Haywood]

well, I am better at Groovy then Java, but ill give it a try !

To view this discussion on the web, visit https://groups.google.com/d/msgid/vertx/C888B913-D1AA-43CF-95CD-9394973C32A8%40julienviet.com.