1. about the name:
I think the name is good
2. about codding style:
maybe Im too nagging but such as there is NO full documentation I have to learn your api by reading your code. And some parts of your code are hard-readable. For example
Ive just copy first "strange parts" of code Ive faced with:
case PRESERVE_ASPECT:tgt.size.set(size.x*(float)t.scaleValue,size.y*(float)t.scaleValue);break;
not enough indentations;
public void draw(){
// gl.glPushMatrix();
// gl.glBegin(GL.GL_QUADS);
// gl.glCallList(this.listId);
// gl.glEnd();
// gl.glPopMatrix();
}
so much such "fully" commented functions. Why do we need them?
4. about javascript and using getters/ setters please dont make it look like javascript. Java is object oriented and code should be serious object oriented. Javascript solves more trivial questions.
Getters / setters maybe unnecessary, but if you design good api they should be part of your system. Because if you dont use them then you break the encapsulation. But I have not something to say about api architecture bacause I didnt learn all your code
5. i think MOST IMPORTANT what you should do are DOCUMENTATION AND SAMPLES
Nobody will use api without good documentation. Because its really hard. You need to write Javadoc and tutorials. I know making documentation is annoying, but they are necessarily. At least you have to make samples how to use your api. not just how to load them from xml or json, but also how to resize, change, add new shapes, and text, change text and so.
I think good point to start is samples, then documentation, then code improvements
вторник, 9 октября 2012 г., 5:13:22 UTC+9 пользователь siliconeagle написал: