Re: [v8-dev] run-tests.py fails

[Daniel Ehrenberg]

Thanks for reporting this issue. Which V8 version are you using? I'm
having trouble reproducing those results.

Dan

On Mon, Jul 10, 2017 at 2:05 AM, Holmes He <egbere...@gmail.com> wrote:
> environment: mac
>
> Error: Failure: expected <11/11/1500>, found <12/10/1500>.
> at fail (/.../v8/v8/test/intl/assert.js:105:9)
> at assertEquals (/.../v8/v8/test/intl/assert.js:114:5)
> at /Users/holmeshe/.../v8/v8/test/intl/date-format/format-test.js:50:1
>
> fix:
> @test/intl/date-format/format-test.js:50
> assertEquals('12/11/1500', dtf.format(new
> Date(Date.UTC(1500,11,11,12,0,0))));
>
> --
> --
> v8-dev mailing list
> v8-...@googlegroups.com
> http://groups.google.com/group/v8-dev
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-dev+un...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Holmes He]

---------- Forwarded message ----------
From: Holmes He <egbere...@gmail.com>
Date: Wed, Jul 12, 2017 at 12:01 PM
Subject: Re: [v8-dev] run-tests.py fails
To: Daniel Ehrenberg <litt...@chromium.org>

It is 8:)

Should be this:

 11 #define V8_MAJOR_VERSION 6

 12 #define V8_MINOR_VERSION 1

I'm following the tutorial from here:

https://github.com/v8/v8/wiki/Building-from-Source

And I am on commit d8d8f8b316 as a result.

My understanding is the month in javascript starts from 0, so 11/11 as the assert string does not make sense. Moreover, if a date is generated using Date(***), the result varies on machines with different timezone.

I hope this helps.

> email to v8-dev+unsubscribe@googlegroups.com.

[Daniel Ehrenberg]

Oh, I see, if I run the test in a timezone like UTC+14, it does fail.
Thanks again for reporting this issue. i have a fix out for review at
https://chromium-review.googlesource.com/c/568021/ .

Dan

>> > email to v8-dev+un...@googlegroups.com.

>> > For more options, visit https://groups.google.com/d/optout.
>
>
>

> --
> --
> v8-users mailing list
> v8-u...@googlegroups.com
> http://groups.google.com/group/v8-users

> ---
> You received this message because you are subscribed to the Google Groups

> "v8-users" group.

> To unsubscribe from this group and stop receiving emails from it, send an

> email to v8-users+u...@googlegroups.com.