Thanks Matthew!
I am keenly interested in making Umlaut more useful to those without SFX
-- even though we still use SFX here (for now), I have been gradually
reducing the parts of SFX that our own Umlaut configuration uses,
replacing with more dependable parts built into Umlaut (for instance,
working on switching to Umlaut-generated links out to ILLiad instead of
relying on SFX for them).
Much of the stuff you've done sounds pretty interesting to me, for sure.
Some of it, it might make more sense to release as an extra plug-in gem,
rather than built into Umlaut. (No difference in how you write the code,
just a question of where it lives).
I totally agree and appreciate your pushing fixes upstream to Umlaut
instead of just making local changes. However, in this case, local
configuration of display text and labels like this is totally expected
for Umlaut installations, everyone won't agree on these. (although also
in this case it's totally appropriate to update the defaults, thanks for
the pull request; it's hard to keep it up to date when the company keeps
switching the name back and forth every couple years!).
I am curious why you are concerned with the debug info being included on
the page? Although I have no problems with a pull request to make it
suppressable with configuration, would be happy to review that. For us
here, we find that debug info truly invaluable for troubleshooting
access problems. But if you think it's a security concern, for instance,
I am very interested to know why in case it's something I should be
concerned about too!
Also, just to make sure you know, since you are about to go live with
Umlaut, I am currently working on the next major relase of Umlaut, which
among other things will support (and may require) Rails 4.x.
Jonathan