RFC commission module

[Cédric Krier]

Hi,

I created a blueprint for sale commission at
https://code.google.com/p/tryton/wiki/CommissionModule

--
Cédric Krier - B2CK SPRL
Email/Jabber: cedric...@b2ck.com
Tel: +32 472 54 46 59
Website: http://www.b2ck.com/

[Cédric Krier]

On 20 Oct 13:12, Cédric Krier wrote:
> Hi,
>
> I created a blueprint for sale commission at
> https://code.google.com/p/tryton/wiki/CommissionModule

I will have also latter to implement a different kind of commission
computation. It is from the point of view of the company a commission
that it will receive by saling some services and collecting the
payments. So it must send back to the supplier the sale minus its
commission. My main issue is that I don't have a name for such thing.
Anyone?

[Nicolas Évrard]

* Cédric Krier [2014-10-21 11:33:58 +0200]

> On 20 Oct 13:12, Cédric Krier wrote:
> > Hi,
> >
> > I created a blueprint for sale commission at
> > https://code.google.com/p/tryton/wiki/CommissionModule
>
> I will have also latter to implement a different kind of commission
> computation. It is from the point of view of the company a commission
> that it will receive by saling some services and collecting the
> payments. So it must send back to the supplier the sale minus its
> commission. My main issue is that I don't have a name for such thing.
> Anyone?

Wikipedia uses "incentives" when it is seen from the agent perspective.

--
Nicolas Évrard - B2CK SPRL
E-mail/Jabber: nicolas...@b2ck.com

[Cédric Krier]

On 21 Oct 12:28, Nicolas Évrard wrote:
> * Cédric Krier [2014-10-21 11:33:58 +0200]
> > On 20 Oct 13:12, Cédric Krier wrote:
> > > Hi,
> > >
> > > I created a blueprint for sale commission at
> > > https://code.google.com/p/tryton/wiki/CommissionModule
> >
> > I will have also latter to implement a different kind of commission
> > computation. It is from the point of view of the company a commission
> > that it will receive by saling some services and collecting the
> > payments. So it must send back to the supplier the sale minus its
> > commission. My main issue is that I don't have a name for such thing.
> > Anyone?
>
> Wikipedia uses "incentives" when it is seen from the agent perspective.

I don't think, incentives is more for local employees.

--
Cédric Krier - B2CK SPRL
Email/Jabber: cedric...@b2ck.com

[Farid Shahy]

On 10/21/2014 01:03 PM, Cédric Krier wrote:
> On 20 Oct 13:12, Cédric Krier wrote:
>> Hi,
>>
>> I created a blueprint for sale commission at
>> https://code.google.com/p/tryton/wiki/CommissionModule
> I will have also latter to implement a different kind of commission
> computation. It is from the point of view of the company a commission
> that it will receive by saling some services and collecting the
> payments. So it must send back to the supplier the sale minus its
> commission. My main issue is that I don't have a name for such thing.
> Anyone?
>

what do you think about broker?

--
Farid Shahy - فرید شاهی
Website: www.fshahy.ir
E-Mail: fsh...@gmail.com

[Cédric Krier]

On 21 Oct 14:19, Farid Shahy wrote:
>
> On 10/21/2014 01:03 PM, Cédric Krier wrote:
> >On 20 Oct 13:12, Cédric Krier wrote:
> >>Hi,
> >>
> >>I created a blueprint for sale commission at
> >>https://code.google.com/p/tryton/wiki/CommissionModule
> >I will have also latter to implement a different kind of commission
> >computation. It is from the point of view of the company a commission
> >that it will receive by saling some services and collecting the
> >payments. So it must send back to the supplier the sale minus its
> >commission. My main issue is that I don't have a name for such thing.
> >Anyone?
> >
>
> what do you think about broker?

It sounds good. It could be a module commission_broker.

[Cédric Krier]

On 20 Oct 13:12, Cédric Krier wrote:

> Hi,
>
> I created a blueprint for sale commission at
> https://code.google.com/p/tryton/wiki/CommissionModule

Does it make sense to design to allow to manage agent at invoice line?
Or is it overengineering?

[Albert Cervera i Areny]

2014-10-21 18:03 GMT+02:00 Cédric Krier <cedric...@b2ck.com>:
> On 20 Oct 13:12, Cédric Krier wrote:
>> Hi,
>>
>> I created a blueprint for sale commission at
>> https://code.google.com/p/tryton/wiki/CommissionModule
>
> Does it make sense to design to allow to manage agent at invoice line?

It does. I've seen real world cases for that.

> Or is it overengineering?
>
> --
> Cédric Krier - B2CK SPRL
> Email/Jabber: cedric...@b2ck.com
> Tel: +32 472 54 46 59
> Website: http://www.b2ck.com/

--
Albert Cervera i Areny
Tel. 93 553 18 03
@albertnan
www.NaN-tic.com

[Raimon Esteve]

2014-10-20 13:12 GMT+02:00 Cédric Krier <cedric...@b2ck.com>:
> Hi,
>
> I created a blueprint for sale commission at
> https://code.google.com/p/tryton/wiki/CommissionModule

And idea o base module about Sale Commission:

https://bitbucket.org/nantic/trytond-sale_commission

Regards,

--
Raimon Esteve

[Cédric Krier]

I did not know about it but after a quick look, I have some issue with
its design:

- It creates supplier invoice for commission. For me, it is wrong.
Supplier invoice must be created only when the supplier really
send you an invoice.
- It is hardly linked to sale. I think commission could happen even
if there is no prior sale.
- The commission is computed on the invoice amount while I think
agent can have different commission (and even no commission)
depending of the product sold.
- It creates commission only when the invoice is paid (partially). I
think there are business where commission is due on invoice
posting.
- It doesn't create a hard link between commission and invoice.
- If the invoice is cancelled, the commission is not.
- It adds agent information on Party. I think it should be avoided
to bloat the party like that (especially the is_* boolean).

There are just one feature not in my design which is that it creates
commission on payment of a term (partial payment). But such feature
prevents to have commission base on product sold. So I don't think it is
really a key feature if you have commmission "On Posting" and "On
Payment".

[Cédric Krier]

On 21 Oct 19:24, Cédric Krier wrote:
> On 20 Oct 13:32, Raimon Esteve wrote:
> > 2014-10-20 13:12 GMT+02:00 Cédric Krier <cedric...@b2ck.com>:
> > > Hi,
> > >
> > > I created a blueprint for sale commission at
> > > https://code.google.com/p/tryton/wiki/CommissionModule
> >
> > And idea o base module about Sale Commission:
> >
> > https://bitbucket.org/nantic/trytond-sale_commission
>
> I did not know about it but after a quick look, I have some issue with
> its design:
>
> - It creates supplier invoice for commission. For me, it is wrong.
> Supplier invoice must be created only when the supplier really
> send you an invoice.
> - It is hardly linked to sale. I think commission could happen even
> if there is no prior sale.
> - The commission is computed on the invoice amount while I think
> agent can have different commission (and even no commission)
> depending of the product sold.
> - It creates commission only when the invoice is paid (partially). I
> think there are business where commission is due on invoice
> posting.

And I forget,

When posting the invoice, we should already register the
commission that will decrease the revenue of the company (draft
move) otherwise you got a over rated revenue.

[Cédric Krier]

On 20 Oct 13:12, Cédric Krier wrote:

> Hi,
>
> I created a blueprint for sale commission at
> https://code.google.com/p/tryton/wiki/CommissionModule

Here is the review for commission module:
http://codereview.tryton.org/13641002