Togglz filter IllegalStateException

[Marcin Grzejszczak]

Hi!

Sorry for spamming you again ;) but there is an exception being thrown constantly when we deployed the app:

java.lang.IllegalStateException: HttpServletRequestHolder.bind() called for a thread that already has a request associated with it. It's likely that the request was not correctly removed from the thread before it is put back into the thread pool.

        at org.togglz.servlet.util.HttpServletRequestHolder.bind(HttpServletRequestHolder.java:22) ~[togglz-servlet-2.0.0.Final.jar:na]

        at org.togglz.servlet.util.HttpServletRequestHolderListener.begin(HttpServletRequestHolderListener.java:25) ~[togglz-servlet-2.0.0.Final.jar:na]

        at org.togglz.servlet.CompositeRequestListener.begin(CompositeRequestListener.java:36) ~[togglz-servlet-2.0.0.Final.jar:na]

        at org.togglz.servlet.TogglzFilter.doFilter(TogglzFilter.java:97) [togglz-servlet-2.0.0.Final.jar:na]

        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256) [web-core.jar:3.1.2.1-SNAPSHOT]

        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:217) [web-core.jar:3.1.2.1-SNAPSHOT]

        at org.togglz.servlet.TogglzFilter.doFilter(TogglzFilter.java:100) [togglz-servlet-2.0.0.Final.jar:na]

        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256) [web-core.jar:3.1.2.1-SNAPSHOT]

        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:217) [web-core.jar:3.1.2.1-SNAPSHOT]

Our configuraiton is shown here (https://groups.google.com/forum/#!topic/togglz-users/1dicN_4nYr0)

Any idea what is wrong? it's happening for every request

BR,

Marcin

[Christian Kaltepoth]

Hey Marcin,

Togglz stores the current request in a ThreadLocal. This exception tells you that the ThreadLocal which Togglz uses for this already has a value set, which may happen if the ThreadLocal isn't cleaned correctly before the thread is put back into the worker pool.

In your case it seems like the TogglzFilter is registered twice (see stacktrace, there are two occurrences of the TogglzFilter). The first run of the filter stores the request in the ThreadLocal and therefore the second run fails with this exception. You should double check your configuration for duplicated entries. In Servlet 3.0 environments you don't need to register the filter at all, because it is automatically registered.

Christian

2013/9/27 Marcin Grzejszczak <marcin.gr...@gmail.com>

--

Christian Kaltepoth

Blog: http://blog.kaltepoth.de/

Twitter: http://twitter.com/chkal

GitHub: https://github.com/chkal

[Marcin Grzejszczak]

Thx for the update.

We have servlet 2.5 environment and this is the Togglz Part (web.xml):

....

    <filter>

        <filter-name>togglzFilter</filter-name>

        <filter-class>org.togglz.servlet.TogglzFilter</filter-class>

    </filter>

....

  <filter-mapping>

        <filter-name>togglzFilter</filter-name>

        <url-pattern>/*</url-pattern>

    </filter-mapping>

....

    <servlet>

        <servlet-name>TogglzConsoleServlet</servlet-name>

        <servlet-class>org.togglz.console.TogglzConsoleServlet</servlet-class>

    </servlet>

Have I made a mistake with such config?

[Christian Kaltepoth]

Hey Marcin,

looks very good. But as you saw in the stacktrace, the filter is executed twice. Is there anything special about your setup? So you have version="2.5" in your <web-app> XML root element?

See here:

        at org.togglz.servlet.util.HttpServletRequestHolder.bind(HttpServletRequestHolder.java:22) ~[togglz-servlet-2.0.0.Final.jar:na]
        at org.togglz.servlet.util.HttpServletRequestHolderListener.begin(HttpServletRequestHolderListener.java:25) ~[togglz-servlet-2.0.0.Final.jar:na]
        at org.togglz.servlet.CompositeRequestListener.begin(CompositeRequestListener.java:36) ~[togglz-servlet-2.0.0.Final.jar:na]
        at org.togglz.servlet.TogglzFilter.doFilter(TogglzFilter.java:97) [togglz-servlet-2.0.0.Final.jar:na]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256) [web-core.jar:3.1.2.1-SNAPSHOT]
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:217) [web-core.jar:3.1.2.1-SNAPSHOT]
        at org.togglz.servlet.TogglzFilter.doFilter(TogglzFilter.java:100) [togglz-servlet-2.0.0.Final.jar:na]
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:256) [web-core.jar:3.1.2.1-SNAPSHOT]

2013/9/27 Marcin Grzejszczak <marcin.gr...@gmail.com>

[Marcin Grzejszczak]

Yeah that's what I have:

<web-app version="2.5" xmlns="http://java.sun.com/xml/ns/javaee"

xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd">

[Christian Kaltepoth]

Which container are you using? And which version?

2013/9/27 Marcin Grzejszczak <marcin.gr...@gmail.com>

[Sean Adkinson]

This was happening to me as well, and I found the cause.

I haven't figured out the best way to fix it yet, but this is happening because you are registering the TogglzFilter like normal, but it is also being registered via META-INF/web-fragment.xml in togglz-servlet.jar.  My application needs to run on both Tomcat 6 (which doesn't read web-fragment.xml) and Tomcat 7 (which does), so I'll have to figure out what to do about this.

Any suggestions?

[Sean Adkinson]

RE: https://groups.google.com/forum/#!topic/togglz-users/vM8alPVUUxM

[Christian Kaltepoth]

Hey Sean,

you can let Tomcat ignore the web-fragment.xml file by adding an empty <absolute-ordering/> element in your web.xml. But this is a Servlet 3.0 feature, so you have to set the version in your web.xml to 3.0. Not sure if Tomcat 6.0 will like this. But it's worth a try.

Christian

2013/12/31 Sean Adkinson <sean.a...@gmail.com>

RE: https://groups.google.com/forum/#!topic/togglz-users/vM8alPVUUxM

[Christian Kaltepoth]

After thinking about this a bit more, actually Tomcat 7 _should_ ignore web-fragment.xml if the version in web.xml is set to 2.5. Can you confirm this?

2013/12/31 Christian Kaltepoth <chri...@kaltepoth.de>

[Sean Adkinson]

Adding <absolute-ordering/> does indeed solve the issue.  Thanks!

Actually, my servlet version is set to 2.4 (which is strange, I didn't expect that).  I work on a large application that's been around a number of years, so I won't update to 2.5 or 3.0 right now.

Thanks for the fix,

Sean

--

Sean Adkinson

Senior Software Engineer - Jama Software

(503) 866-0852 | sean.a...@gmail.com