[Android] - images from res-...-xxhdpi folder not displayed

[Association RVVN RVVN]

Hi,

I've tested an app on Galaxy S4 in 480dpi (Genymotion) and images from res-...-xxhdpi folder are not displaying.

I also tried with TiShadow built against Titanium 3.2 SDK (which handles xxhdpi folders as I know) without any success.

[David Bankier]

Just pushed a fix to master.

David

[Association RVVN RVVN]

Hi David,

Thanks for replying and fixing.

It works like a charm !

But after tishadow update from master, executing a "run --update" now throws the following error :

assert.js:92

  throw new assert.AssertionError({

        ^

AssertionError: path must be a string

    at Module.require (module.js:362:3)

    at require (module.js:380:17)

    at Object.exports.mapFiles (/usr/local/lib/node_modules/tishadow/cli/support/alloy.js:17:22)

    at /usr/local/lib/node_modules/tishadow/cli/support/compiler.js:84:43

    at /usr/local/lib/node_modules/tishadow/cli/support/config.js:80:5

    at /usr/local/lib/node_modules/tishadow/cli/support/config.js:19:5

    at /usr/local/lib/node_modules/tishadow/node_modules/tiapp/lib/tiapp.js:19:15

    at Parser.<anonymous> (/usr/local/lib/node_modules/tishadow/node_modules/tiapp/node_modules/xml2js/lib/xml2js.js:255:20)

    at Parser.EventEmitter.emit (events.js:95:17)

    at Object.saxParser.onclosetag (/usr/local/lib/node_modules/tishadow/node_modules/tiapp/node_modules/xml2js/lib/xml2js.js:225:24)

I've updated tishadow doing "npm install -g git://github.com/dbankier/TiShadow.git"

Is that the right way ?

[Association RVVN RVVN]

Hi,

I fix this issue by replacing "previous_map_file" with "config.alloy_map_path" in exports.mapFiles (file "cli/support/alloy.js", line 17).
Seems to be related to this commit regarding fixes for new xml2js module : https://github.com/dbankier/TiShadow/commit/4e9ec0c33e327830bebc572eafea438076c4cf93

[...]

exports.mapFiles = function(last_stat) {

  // full build if the previous map doesn't exits

  if (!fs.existsSync(config.alloy_map_path)) {

    return file_list;

  }

  var previous_map = require(config.alloy_map_path);

  file_list.files = file_list.files.filter(function(file) {

      return current_map[file] !== previous_map[file];

  });

  return file_list;

};

[...]

[David Bankier]

Hi,

I fixed this yesterday with this commit: https://github.com/dbankier/TiShadow/commit/4e9ec0c33e327830bebc572eafea438076c4cf93

David

[Association RVVN RVVN]

Oops, sorry, Github didn't display me the changes on home page.

Thanks by the way !

[David Bankier]

No problem. Enjoy.