Palette causing "TypeError: rgbColourA is null"

[Rustem]

When I switch to a custom palette, TiddlyWiki starts throwing "TypeError: rgbColourA is null". What am I missing, or is this a bug?

(Edit: here is a gist with the palette contents: https://gist.github.com/nameanyone/546eec31eab05fc350a6)

Thanks.

R.

[Jeremy Ruston]

Hi Rustem

What browser/OS are you using? I'm guessing that the palette isn't properly formed, perhaps with missing entries; did you start by cloning one of the existing palettes? Can you post an example for me to look at?

Best wishes

Jeremy.

On Sun, Apr 19, 2015 at 9:32 PM, Rustem <8pa...@gmail.com> wrote:

When I switch to a custom palette, TiddlyWiki starts throwing "TypeError: rgbColourA is null". What am I missing, or is this a bug?

Thanks.

R.

--
You received this message because you are subscribed to the Google Groups "TiddlyWiki" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tiddlywiki+...@googlegroups.com.
To post to this group, send email to tiddl...@googlegroups.com.
Visit this group at http://groups.google.com/group/tiddlywiki.
To view this discussion on the web visit https://groups.google.com/d/msgid/tiddlywiki/b678d92f-3fda-4b85-89ab-40fd361739b2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Jeremy Ruston
mailto:jeremy...@gmail.com

[Rustem]

Firefox/Windows. Here’s how to reproduce: edit Vanilla shadow tiddler and replace

background: #ffffff

with

bgr: #ffffff
background: <<colour bgr>>

[Jeremy Ruston]

Hi Rustem

Thanks, that's very helpful.

The problem is actually with the "contrastcolour" macro which is used by the default tag template. In this case, it doesn't understand the <<colour ???>> syntax for the "foreground" and "background" colours.

I've fixed it here:

https://github.com/Jermolene/TiddlyWiki5/commit/75a33f5dff97a9a5850558192c4a2b74b3cb3233

Even with the fix, tag pill rendering will be improved by using literal colours for the foreground and background colours.

Best wishes

Jeremy.

[Rustem]

Jeremy,

Even with the fix, tag pill rendering will be improved by using literal colours for the foreground and background colours.

that's because it's a workaround, not a fix, correct? The macro still doesn't understand <<clolour ...>> syntax, it just learned to handle the situation more gracefully?

Also, you probably want to swap A and B in lines 41-42.

Cheers.

R.

[Jeremy Ruston]

Hi Rustem

Also, you probably want to swap A and B in lines 41-42.

Thanks, fixed here:

https://github.com/Jermolene/TiddlyWiki5/commit/3c7082e1816013dd0111f8f6c1459c97ac63fa26

Best wishes

Jeremy.

 

Cheers.

R.