#include "allheaders.h"

369 views
Skip to first unread message

Zdenko Podobný

unread,
Sep 1, 2016, 5:25:22 AM9/1/16
to tesser...@googlegroups.com
Hi all,

I see some people are confused with:
#include "allheaders.h"
 - they expect that file allheaders.h is part for tesseract. I think it would help if we change it to:
#include <leptonica/allheaders.h>

Or you have any better idea?

Zdenko

Egor Pugin

unread,
Sep 11, 2016, 1:24:17 PM9/11/16
to tesseract-dev
It seems that leptonica itself might want to reconsider its public headers structure.
Now all headers are located inside 'src' dir, but the common practice is to have public includes in '/include' folder.
Tesseract in this sense has issues too (4 dirs with public headers that are just in root).

Zdenko Podobný

unread,
Feb 3, 2017, 1:56:37 PM2/3/17
to tesser...@googlegroups.com
So far there are no changes in leptonica.
Any objections to this change?

Zdenko

--
You received this message because you are subscribed to the Google Groups "tesseract-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tesseract-dev+unsubscribe@googlegroups.com.
To post to this group, send email to tesser...@googlegroups.com.
Visit this group at https://groups.google.com/group/tesseract-dev.
To view this discussion on the web visit https://groups.google.com/d/msgid/tesseract-dev/f9eff15d-4e15-4f5c-b3a4-d5adf90e2460%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Egor Pugin

unread,
Feb 3, 2017, 1:58:29 PM2/3/17
to tesseract-dev
Until leptonica has the same structure as before, with this change you'll break everything.
I'm against it.


On Friday, February 3, 2017 at 9:56:37 PM UTC+3, Zdenko Podobný wrote:
So far there are no changes in leptonica.
Any objections to this change?

Zdenko

On Sun, Sep 11, 2016 at 5:39 PM, Egor Pugin <egor....@gmail.com> wrote:
It seems that leptonica itself might want to reconsider its public headers structure.
Now all headers are located inside 'src' dir, but the common practice is to have public includes in '/include' folder.
Tesseract in this sense has issues too (4 dirs with public headers that are just in root).


On Thursday, September 1, 2016 at 12:25:22 PM UTC+3, Zdenko Podobný wrote:
Hi all,

I see some people are confused with:
#include "allheaders.h"
 - they expect that file allheaders.h is part for tesseract. I think it would help if we change it to:
#include <leptonica/allheaders.h>

Or you have any better idea?

Zdenko

--
You received this message because you are subscribed to the Google Groups "tesseract-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to tesseract-de...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages