[ISSUE] (TEPHRA-142) Implement a deadlock proof, resource leak proof transaction client provider

[Poorna Chandra (JIRA)]

Poorna Chandra created an issue

Tephra / TEPHRA-142 Implement a deadlock proof, resource leak proof transaction client provider Issue Type: Improvement Assignee: Ali Anwar Components: core Created: 21/Oct/15 10:12 PM Fix Versions: 0.6.3 Priority: Major Reporter: Poorna Chandra PooledClientProvider has a fixed number of maximum clients it returns. This can lead to deadlock in application. ThreadLocalClientProvider provides one client per thread, so there will be no deadlock. But there is no reliable way of closing the connection when the thread dies, and this leads to connection leaks. Having a provider that has no limit on the number of clients returned will be equivalent to ThreadLocalClientProvider, since the number of clients requested can be capped by the number of threads, if each thread requests one client only. In addition, this provider is already resource leak proof as long as threads always return the clients after usage. If this provider can also timeout idle connections after some time, then this will ensure that we do not hold unnecessary connections when not required. Add Comment

This message was sent by Atlassian JIRA (v6.1.5#6160-sha1:a61a0fc)

[Ali Anwar (JIRA)]

Ali Anwar resolved an issue as Fixed

Merged PR: https://github.com/caskdata/tephra/pull/95 The pull request improves ElasticPool, to be used in place of thread-local client provider. The ElasticPool has a discrepancy from the description in this JIRA in that the ElasticPool does not time out connections (clients). This should be fine, since we limit the number of connections per elastic pool.

Tephra / TEPHRA-142 Implement a deadlock proof, resource leak proof transaction client provider

Change By: Ali Anwar Status: In Progress Resolved Resolution: Fixed

Add Comment

[Poorna Chandra (JIRA)]

Poorna Chandra commented on an issue

Re: Implement a deadlock proof, resource leak proof transaction client provider PR - https://github.com/caskdata/tephra/pull/99 PR - https://github.com/caskdata/tephra/pull/100

Add Comment

Tephra / TEPHRA-142 Implement a deadlock proof, resource leak proof transaction client provider

PooledClientProvider has a fixed number of maximum clients it returns. This can lead to deadlock in application. ThreadLocalClientProvider provides one client per thread, so there will be no deadlock. But there is no reliable way of closing the connection when the thread dies, and this leads to connection leaks.

Having a provider that has no limit o...

[Poorna Chandra (JIRA)]

Poorna Chandra commented on an issue

Re: Implement a deadlock proof, resource leak proof transaction client provider

Porting to tephra-0.4.3 - https://github.com/caskdata/tephra/pull/102

Add Comment

[Poorna Chandra (JIRA)]

Poorna Chandra updated an issue

Tephra / TEPHRA-142 Implement a deadlock proof, resource leak proof transaction client provider

Change By: Poorna Chandra Fix Version/s: 0.4.3

Add Comment

[Poorna Chandra (JIRA)]

Poorna Chandra edited a comment on an issue

Re: Implement a deadlock proof, resource leak proof transaction client provider Porting to tephra-0.4. 3 4  - https://github.com/caskdata/tephra/pull/102

Add Comment

Tephra / TEPHRA-142 Implement a deadlock proof, resource leak proof transaction client provider

PooledClientProvider has a fixed number of maximum clients it returns. This can lead to deadlock in application. ThreadLocalClientProvider provides one client per thread, so there will be no deadlock. But there is no reliable way of closing the connection when the thread dies, and this leads to connection leaks. Having a provider that has no limit o...