[ISSUE] (TEPHRA-119) TransactionEditCodecV4 not getting used in deserialization

2 views
Skip to first unread message

Gary Helmling (JIRA)

unread,
Aug 11, 2015, 8:49:20 PM8/11/15
to tephr...@googlegroups.com
Gary Helmling created an issue
 
Tephra / Bug TEPHRA-119
TransactionEditCodecV4 not getting used in deserialization
Issue Type: Bug Bug
Assignee: Gary Helmling
Components: core
Created: 11/Aug/15 5:47 PM
Priority: Major Major
Reporter: Gary Helmling

When TransactionEditCodecV4 was added it was not hooked in properly to be used in deserialization, so TransactionEditCodecV3 is still being used, leading to dropped fields. In addition, so the current TransactionEditCodec support duplicates code as well as the class references, making mistakes like this likely.

We should refactor the TransactionEditCodec usage to fix this issue and avoid further problems in the future.

Add Comment Add Comment
 
This message was sent by Atlassian JIRA (v6.1.5#6160-sha1:a61a0fc)
Atlassian logo

Gary Helmling (JIRA)

unread,
Aug 11, 2015, 8:53:20 PM8/11/15
to tephr...@googlegroups.com
When TransactionEditCodecV4 was added it was not hooked in properly to be used in deserialization, so TransactionEditCodecV3 is still being used, leading to dropped fields. In addition, so the current TransactionEditCodec support duplicates code as well as the class references, making mistakes like this likely.

We should refactor the TransactionEditCo...

Gary Helmling (JIRA)

unread,
Aug 12, 2015, 2:00:21 PM8/12/15
to tephr...@googlegroups.com

Gary Helmling (JIRA)

unread,
Aug 12, 2015, 2:36:20 PM8/12/15
to tephr...@googlegroups.com
Gary Helmling resolved an issue as Fixed
 

Merged to develop

Change By: Gary Helmling
Status: Open Resolved
Fix Version/s: 0.6.2
Resolution: Fixed
Reply all
Reply to author
Forward
0 new messages