add sympy.test() back?

4 views
Skip to first unread message

Ondrej Certik

unread,
Jun 13, 2011, 1:37:16 AM6/13/11
to sympy
Hi,

I noticed that sympy.test() was removed by this commit:

https://github.com/sympy/sympy/commit/5c3bea3f43115911845c5ad8b1e6a92253c3ba91

but from the commit log it is not clear to me why. I also tried to
search the mailinglist, but didn't find anything. numpy.test(), as
well as scipy.test() is a simple way to test the whole package.
SymPy used to work the same way, it is easy to remember and so on. And
it is very useful to test, that sympy actually works, after it is
being installed (when you can't use the "./setup.py test" anymore).

What was the reason to remove it? Maybe because it slows down the
import time (this can be solved by lazy importing)? Unless there is
some very good reason, I would vote to move it back. Let me know what
you think.

Ondrej

Aaron Meurer

unread,
Jun 13, 2011, 1:46:52 AM6/13/11
to sy...@googlegroups.com
The reason is basically described in the commit message. See
http://code.google.com/p/sympy/issues/detail?id=1379.

I didn't realize that both numpy and scipy import test(). I'm OK to
put it back, if others agree, because you make a good point.

By the way, I found the issue number by opening GitX and commit
https://github.com/sympy/sympy/commit/5bd2e4697828f60a920ef48c6797fa30b9def947.

Aaron Meurer

> --
> You received this message because you are subscribed to the Google Groups "sympy" group.
> To post to this group, send email to sy...@googlegroups.com.
> To unsubscribe from this group, send email to sympy+un...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
>
>

Ondrej Certik

unread,
Jun 13, 2011, 1:59:43 AM6/13/11
to sy...@googlegroups.com
On Sun, Jun 12, 2011 at 10:46 PM, Aaron Meurer <asme...@gmail.com> wrote:
> The reason is basically described in the commit message.  See
> http://code.google.com/p/sympy/issues/detail?id=1379.
>
> I didn't realize that both numpy and scipy import test().  I'm OK to
> put it back, if others agree, because you make a good point.

Btw, I noticed I gave +1 myself to that pull request. :)

> By the way, I found the issue number by opening GitX and commit
> https://github.com/sympy/sympy/commit/5bd2e4697828f60a920ef48c6797fa30b9def947.

I read through the issue and I understand that there is a problem with
running the test in isympy *sometimes*, that is not fixed yet. Right?
But I don't understand how removing it from sympy.* would fix it. So
the ipython issue seems orthogonal to the way test() is imported.

Ondrej

Aaron Meurer

unread,
Jun 13, 2011, 2:01:48 AM6/13/11
to sy...@googlegroups.com

It wasn't intendent to fix that issue. It was just something that I
noticed and I didn't bother to create a new issue for it.

Aaron Meurer

Reply all
Reply to author
Forward
0 new messages