upstream branch to match c++11/math.h refactor

22 views
Skip to first unread message

Bob Carpenter

unread,
Oct 3, 2016, 2:06:27 PM10/3/16
to stan...@googlegroups.com
Here are the dependent branches and the stan-dev/math pull request:

stan-dev/stan branch:
feature/2072-cpp11-math-h-namespaces

stan-dev/math branch:
feature/0370-cp11-cmath-funs-2

stan-dev/math pull request:
https://github.com/stan-dev/math/pull/395

The stan-dev/math pull request is fine other than for the upstream
integration test. Can I run that locally without exploding my computer
with the stan-dev/stan branch I have in place?

The stan-dev/stan branch will fail until stan-dev/math is updated.
I'm not sure what the complete set of tests are that I need to run
locally for stan-dev/stan to make sure everything works.

- Bob



Daniel Lee

unread,
Oct 3, 2016, 5:12:54 PM10/3/16
to stan-dev mailing list
Hi Bob,

I checked out the Stan branch and updated the math branch and it passes all tests.

You can run it locally. From the Stan branch, you can either add a make variable that points to the folder or update the submodule.

The tests I ran:
./runTests.py src/test/integration 
./runTests.py src/test/performance 
./runTests.py src/test/unit

I'm reviewing your pull request now.


Daniel





- Bob



--
You received this message because you are subscribed to the Google Groups "stan development mailing list" group.
To unsubscribe from this group and stop receiving emails from it, send an email to stan-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply all
Reply to author
Forward
0 new messages