discussion on #3348

[Ray Lehtiniemi]

Hi all

Looking at how to properly fix this issue, need feedback on the general approach.

it seems pyobject filter

    https://github.com/sphinx-doc/sphinx/blob/master/sphinx/directives/code.py#L249

uses module analyser

   https://github.com/sphinx-doc/sphinx/blob/master/sphinx/pycode/__init__.py#L183

seems like the def/class clause

   https://github.com/sphinx-doc/sphinx/blob/master/sphinx/pycode/__init__.py#L322

needs to use the spos[0] of the first decorator it saw, rather than the underlying decorated object

so this module needs to be tracking the start position of each new

decorator stack it sees, then use that when it gets to the definition

of the underlying decorated object

does that sound correct?  will that mess up anyone else who's

currently using this module?

Thanks

Ray

[Komiya Takeshi]

Hi,

You're right. I agree with you.

>will that mess up anyone else who's currently using this module?

As a quick look, the analyzer is used from following modules.

$ grep -lr Analyzer sphinx
sphinx/directives/code.py
sphinx/ext/autodoc.py
sphinx/ext/autosummary/__init__.py
sphinx/ext/inheritance_diagram.py
sphinx/ext/viewcode.py
sphinx/pycode/__init__.py
sphinx/websupport/search/whooshsearch.py

It seems some modules depends on the analyazer.
so we need to modify it carefully.

Thanks,

> --
> You received this message because you are subscribed to the Google Groups
> "sphinx-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to sphinx-dev+...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Ray Lehtiniemi]

On Thursday, March 9, 2017 at 10:24:26 PM UTC-7, Komiya Takeshi wrote:

 

sphinx/directives/code.py
sphinx/ext/viewcode.py 

looks like these two are the ones that use the find_tags() method, which is the one impacted by the change

 

sphinx/ext/autodoc.py
sphinx/ext/autosummary/__init__.py
sphinx/ext/inheritance_diagram.py
sphinx/pycode/__init__.py

these guys don't seem like they will be impacted...

 

sphinx/websupport/search/whooshsearch.py

i didn't see where this one used the analyser

 

i posted a new pull request for review.  it seems to work for the literalinclude and viewcode cases, and 'make tests' still passes for me.

Thanks