Github OAuth integration

62 views
Skip to first unread message

Justin Wyer

unread,
Jul 11, 2012, 1:57:36 AM7/11/12
to social...@googlegroups.com
Heys I've made an issue for this https://github.com/ocpsoft/socialpm/issues/11

Things still to be investigated would be:
  1. How much do we need (or want) to store about the user.
  2. If github (or another provider) is unreachable what should happen to the SocialPM instance, could we simply fail gracefully to some sort of read only state until communications are restored?

Justin Wyer

unread,
Jul 12, 2012, 3:44:17 AM7/12/12
to social...@googlegroups.com
Should we implement github.com support for seam social? This will allow us to use seam security via the seam social oauth integration. Will investigate the effort.

Lincoln Baxter

unread,
Jul 12, 2012, 10:49:09 AM7/12/12
to social...@googlegroups.com

Awesome, thanks justin :)

Yeah that may is a good way to go. Seam social is likely going to need to be integrated at some point anyway.

Originally we were using seam security external. But there were some problems getting that to work nicely and consistently. Seam social took over that effort.

Lincoln

Lincoln Baxter

unread,
Jul 12, 2012, 10:50:22 AM7/12/12
to social...@googlegroups.com

I think all we want to store is their email address and user name from gh. What else would we need do you think?

Justin Wyer

unread,
Jul 12, 2012, 2:33:11 PM7/12/12
to social...@googlegroups.com
Okay so the plan is as follows:

We need to implement GithubApi for scribe-java, it looks like someone has taken a stab at this, but upstream has so far refused the pulls for various reasons, I will take a look and either fix up the current attempt or just implement it myself.

Once that is done I should have the seam social for github going pretty quick, already hacked something together, it just needs the scribe-java bit to begin testing.

I'll try get the scribe and seam social bits done this weekend, that will at least remove the restrictions in getting the SocialPM dev going on this, then if anyone else wants to poke at it next week they can, else I will work on it as time allows but definitely next weekend.

Justin Wyer

unread,
Jul 13, 2012, 3:48:54 PM7/13/12
to social...@googlegroups.com
scribe-java has github support, i've submitted a pull upstream.
seam-social has github support, we can fetch a user profile!

Lincoln Baxter

unread,
Jul 13, 2012, 3:52:39 PM7/13/12
to social...@googlegroups.com

Nice!

Let's go with seam social.

Justin Wyer

unread,
Jul 13, 2012, 4:14:17 PM7/13/12
to social...@googlegroups.com
Yeah I'll post some instructions on where to pull scribe-java and seam-social from my forks. Until the scribe-java pull request is integrated we'll have to build it ourselves.

Lincoln Baxter

unread,
Jul 13, 2012, 4:15:12 PM7/13/12
to social...@googlegroups.com

So we do need scribe java as well?

Justin Wyer

unread,
Jul 13, 2012, 4:32:16 PM7/13/12
to social...@googlegroups.com
Yeah, its a dependency of seam social.

Justin Wyer

unread,
Jul 13, 2012, 4:39:43 PM7/13/12
to social...@googlegroups.com
Okay so while we're waiting on upstreams, you can build my temp branch of scribe-java https://github.com/justinwyer/scribe-java/tree/temp and my github branch of seam social https://github.com/justinwyer/social/tree/github

If upstream is not forthcoming we can always look at publishing our own scribe-java, in the mean time I will carry on with this, and get signup via github going in SocialPM we can worry about logistics later ;)

Lincoln Baxter, III

unread,
Jul 20, 2012, 3:14:01 PM7/20/12
to social...@googlegroups.com
From our conversation on Twitter. Does using Agorava change any of our dependencies? Is there a stable (non-SNAPSHOT) version we can use for now?

~Lincoln
--
Lincoln Baxter, III
http://ocpsoft.org
"Simpler is better."

Justin Wyer

unread,
Jul 21, 2012, 3:05:40 AM7/21/12
to social...@googlegroups.com, lin...@ocpsoft.org
Hi Lincoln, yes we will have to add a dependency for Agorava Github module there is no stable version :P
Reply all
Reply to author
Forward
0 new messages