Deprecation notices in 3.2 onwards

[Damian Mooyman]

Hi all,

There has been a bit of discussion as to how we should be handling deprecation notices in framework. Many users find the notices raised intrusive, sometimes giving module developers the impression that they need to re-version their modules each framework version in order to suppress these. Others are happy for these errors to be raised, and would rather use php error_reporting to suppress E_USER_DEPRECATED.

I suggest that perhaps these notices should be disabled entirely by default, and instead we should allow these to be enabled by default. I'm suggesting a possible API addition to go into 3.2 to address this.

https://github.com/silverstripe/silverstripe-framework/pull/4264

How do users feel about this?

Kind regards,

Damian Mooyman

[Ralph Slooten]

Hi Damian,

I don't agree. Personally I feel that depreciation notices are very important for devs, and I don't see the point of having to explicitly turn it on while in dev mode (isn't that one of the points of dev mode?). By hiding depreciation warnings (by default), I think one only introduces a long term issue whereby depreciations may go unnoticed until it literally breaks the code.

No live website should be in dev mode anyway, so they aren't affected, and if one is working on code that includes depreciated functionality and for whatever reason cannot (or will not) update it, then notices can be turned off manually (at the dev's own risk).

Just my 5c.

Kind regards,
Ralph

--
You received this message because you are subscribed to the Google Groups "SilverStripe Core Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to silverstripe-d...@googlegroups.com.
To post to this group, send email to silverst...@googlegroups.com.
Visit this group at http://groups.google.com/group/silverstripe-dev.
For more options, visit https://groups.google.com/d/optout.

[Michael Strong]

I'm with Ralph. Dev's should be made aware that there code is going to break before it actually breaks and they should explicitly choose to ignore the deprecation warnings.

--

Michael Strong | Platform Support Developer
SilverStripe
http://silverstripe.com/

Phone: +64 4 978 7330
Skype: micmania1

[Florian Thoma]

I agree with Ralph and Michael. It is easy enough to disable the errors with error_reporting.