Versioned::choose_site_stage should not rely on Session

[g4b0]

Hi all,
Like in subject, I think that Versioned::choose_site_stage should rely only on GET param, it should not be written in session since end user are not advised that they are viewing a Stage site, causing unnecessary alarm to the less clever ones.

g4b0

[Thierry Francois (colymba)]

I would agree. I've been having all sorts of issues not knowing which stage am in anymore or coming back to a site later on and seeing the Draft stage instead of the Live one..

..making things very confusing...

T

[Daniel Hensby]

I can't say I agree it should be in the URL, it'd mean having to re-write all URLs on the page depending on the stage to make sure state wasn't lost when navigating from one page to another.

Really, a better solution is some kind of banner, flag or notice that conveys "you're viewing the draft site".

Daniel Hensby Director

e: daniel...@betterbrief.co.uk t:  020 7183 9266 w: http://www.betterbrief.co.uk

--
You received this message because you are subscribed to the Google Groups "SilverStripe Core Development" group.
To unsubscribe from this group and stop receiving emails from it, send an email to silverstripe-d...@googlegroups.com.
To post to this group, send email to silverst...@googlegroups.com.
Visit this group at http://groups.google.com/group/silverstripe-dev.
For more options, visit https://groups.google.com/d/optout.

[g4b0]

It depends on the use case. Maybe a better solution is to have its behaviour decided by a config value, having the actual as default.

[g4b0]

PR here: https://github.com/silverstripe/silverstripe-framework/pull/3605

[Thierry Francois (colymba)]

Having it in the URL probably isn't the best for sure.

But having some kind of tool/banner to switch back and some kind of flag in the cms would be great, because things get very confusing quickly (something been talked about in other threads I think).

My main issue is in the cms when the "preview pane" shows up (99% of the time I didn't even ask to see it) which stets the stage for the site, and even after closed the stage is keep for the rest of the time.

Having to reopen the preview pane to switch back stage isn't practical. But this all think is probably better talked about here: https://groups.google.com/forum/#!topic/silverstripe-dev/JGtcs9sF1Aw

I do like the idea of having the option to having the stage persist or not though.

[Stevie Mayhew]

I agree - its extremely confusing. 

There is http://addons.silverstripe.org/add-ons/jonom/silverstripe-betternavigator which provides a nice little flag showing whether you are in staging or live mode which alleviates some of the pain :)

[Damian Mooyman]

You should check out the SS navigator feature. It allows you to put a mini "admin" bar on the page which isn't visible to non editors. It shows the current stage and provides a convenient CMS link and version changing link.

$SilverStripeNavigator

Does that work?

[g4b0]

It seems interesting, but it's the first time I see it. From which version of SS it's around?

[Thierry Francois (colymba)]

SS Navigator is all fine (although I prefer not to use those toolbars), but a simple switch in the CMS would go a long way :)