Werid test failures on kfreebsd-*

[Joachim Breitner]

Hi,

sigh, it’s me again, and I have failing tests that may or may not be
shake’s fault.

On kfreebsd-amd64 and kfreebsd-i386, shake 0.12.2 used to build just
fine, e.g.
https://buildd.debian.org/status/fetch.php?pkg=haskell-shake&arch=kfreebsd-i386&ver=0.15.2%2Bdfsg-1&stamp=1434214748

But my recent upload, which changed nothing on non-powerpc
-architectures, now fails to build:
https://buildd.debian.org/status/fetch.php?pkg=haskell-shake&arch=kfreebsd-i386&ver=0.15.2%2Bdfsg-2&stamp=1434880454
https://buildd.debian.org/status/fetch.php?pkg=haskell-shake&arch=kfreebsd-i386&ver=0.15.2%2Bdfsg-2&stamp=1434894638
https://buildd.debian.org/status/fetch.php?pkg=haskell-shake&arch=kfreebsd-i386&ver=0.15.2%2Bdfsg-2&stamp=1434904503

There is some non-determinism involved, as the failures vary; I see

Error when running Shake build system:
* capture
ASSERTION FAILED: failed in ===
LHS: "1\n3\n2\n"
RHS: "1\n2\n3\n"

or

Error when running Shake build system:
* file
ASSERTION FAILED: File contents are wrong: output/command/file.txt
WANT: foo
bar
baz

GOT: foo
baz
bar

Any idea what these test failures should tell me?

Greetings,
Joachim

--
Joachim “nomeata” Breitner
ma...@joachim-breitner.de • http://www.joachim-breitner.de/
Jabber: nom...@joachim-breitner.de • GPG-Key: 0xF0FBF51F
Debian Developer: nom...@debian.org

[Neil Mitchell]

Hi,

> But my recent upload, which changed nothing on non-powerpc
> -architectures, now fails to build:
> https://buildd.debian.org/status/fetch.php?pkg=haskell-shake&arch=kfreebsd-i386&ver=0.15.2%2Bdfsg-2&stamp=1434880454
> https://buildd.debian.org/status/fetch.php?pkg=haskell-shake&arch=kfreebsd-i386&ver=0.15.2%2Bdfsg-2&stamp=1434894638
> https://buildd.debian.org/status/fetch.php?pkg=haskell-shake&arch=kfreebsd-i386&ver=0.15.2%2Bdfsg-2&stamp=1434904503
>
> There is some non-determinism involved, as the failures vary; I see
>
> Error when running Shake build system:
> * capture
> ASSERTION FAILED: failed in ===
> LHS: "1\n3\n2\n"
> RHS: "1\n2\n3\n"
>
> or
>
> Error when running Shake build system:
> * file
> ASSERTION FAILED: File contents are wrong: output/command/file.txt
> WANT: foo
> bar
> baz
>
> GOT: foo
> baz
> bar
>
> Any idea what these test failures should tell me?

It looks like the stdout/stderr tests have a race condition. I've seen
this once or twice on my buildbot, so I guess it might be more common
on other OS's, but it's probably a Shake bug. I'll take a look and see
if I can make it more robust - tracked as
https://github.com/ndmitchell/shake/issues/264.

Thanks, Neil