Issue 8083 in selenium: Enum missing

[sele...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium Status-Untriaged

New issue 8083 by andrew.p...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

On upgrading my Maven 3 project from 2.43.1 to 2.44.0 attempting to test on
a Windows 2012 platform I get the following exception and stacktrace for
every test that attempts to execute from NUnit 2.6.3:

**START STACKTRACE***
java.lang.IllegalArgumentException: No enum constant
org.openqa.selenium.Platform.Windows 2012
at java.lang.Enum.valueOf(Enum.java:238)
at org.openqa.selenium.Platform.valueOf(Platform.java:30)
at
org.openqa.selenium.remote.DesiredCapabilities.setCapability(DesiredCapabilities.java:168)
at
au.com.fullcirclesolutions.saucery.capabilities.concreteproducts.DesktopCapabilities.<init>(DesktopCapabilities.java:15)
at
au.com.fullcirclesolutions.saucery.capabilities.concretecreators.DesktopCreator.Create(DesktopCreator.java:11)
at
au.com.fullcirclesolutions.saucery.capabilities.CapabilityFactory.CreateCapabilities(CapabilityFactory.java:15)
at
au.com.fullcirclesolutions.saucery.tests.SauceryBase.setUp(SauceryBase.java:65)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:483)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at
org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:318)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
***END STACKTRACE***

What steps will reproduce the problem?
1. Update pom.xml dependency version from 2.43.1 to 2.44.0
2. Attempt to test on Window 2012 platform
3. Get exception

What is the expected output? What do you see instead?
That the test executes on the requested platform as it does on 2.43.1

Selenium version:
OS: Windows 2012
Browser: Chrome
Browser version: 38

Test run on SauceLabs VM.

Downgrading back to 2.43.1 resolves the issue. Tests run successfully on
Windows 2012 platform.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[sele...@googlecode.com]

Updates:
Status: NeedsClarification

Comment #1 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

What is "Windows 2012"? There never was such a value in the Platform enum.
Where it is coming from?

[sele...@googlecode.com]

Comment #2 on issue 8083 by andrew.p...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Value is coming out of Sauce On demand plugin. Not a problem in 2.43.1,
only 2.44.0.

What changed between those two selenium versions to break this?

[sele...@googlecode.com]

Comment #3 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Nothing changed, see the history [1] (release 2.43.1 is dated Sep 10).

Where exactly is the value "Windows 2012" coming from? I bet it should
be "Windows Server 2012" that is present in the Platform enum.

[1]
https://github.com/SeleniumHQ/selenium/commits/master/java/client/src/org/openqa/selenium/Platform.java

[sele...@googlecode.com]

Comment #4 on issue 8083 by teijo.ka...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

I got also:

java.lang.IllegalArgumentException: No enum constant
org.openqa.selenium.Platform.Windows 8.1

java.lang.IllegalArgumentException: No enum constant
org.openqa.selenium.Platform.Windows 7

Downgrading back to older version solved my case.

[sele...@googlecode.com]

Comment #5 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Yes, there are no constants like "org.openqa.selenium.Platform.Windows 7"
(with the package name), they have names like "Windows 7".

Please provide a complete executable scenario that would allow us to
reproduce the issue.

[sele...@googlecode.com]

Comment #6 on issue 8083 by teijo.ka...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

I'm also using SauceLabs (tests built with maven,testng,java,selenium) to
test.

Selected parts from the code:

capability=DesiredCapabilities.firefox();
capability.setCapability("platform", "Windows 8.1");
driver = new RemoteWebDriver(new
URL("http://"+host+":"+port+"/wd/hub"),capability);

[sele...@googlecode.com]

Comment #7 on issue 8083 by piar...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

As far as I can tell, the change associated with the df9aa542b4bc commit
(https://code.google.com/p/selenium/source/detail?r=df9aa542b4bce5824660bac2ca25166b835e60db)
causes the error. Previously the code was allowing arbitrary platform
values to be specified, whereas now the code attempts to perform a lookup
of the Platform enum value.

The https://saucelabs.com/platforms page lists the browser combinations
supported by Sauce Labs and the associated platform value which users are
advised to supply. In addition to requiring users/API calls to change the
platform values included in the DesiredCapabilities, the impact of this
change is that any new platforms supported by Sauce Labs will need to be
included within the Platform enum before they can be used, which is less
than ideal.

[sele...@googlecode.com]

Updates:
Status: Accepted
Labels: -Status-Untriaged Lang-Java

Comment #8 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Ah, got it thanks! The fix is coming...

[sele...@googlecode.com]

Comment #9 on issue 8083 by andrew.p...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Thanks Ross,

Looks like you your comment pushed it over the edge to getting resolved.

[sele...@googlecode.com]

Updates:
Status: Fixed

Comment #10 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

This issue was closed by revision 396f25547a88.

[sele...@googlecode.com]

Comment #11 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Thanks! Also, we need more regression tests :) TBD

[sele...@googlecode.com]

Comment #12 on issue 8083 by andrew.h...@ephox.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Is that actually going to fix it, or just give us the nearest matching
platform which might not be the exact one we asked for?

What if Sauce Labs is actually relying on the value being a string?

I'm sticking with 2.43.1 until this is sorted out :)

[sele...@googlecode.com]

Updates:
Status: Accepted

Comment #13 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

(No comment was entered for this change.)

[sele...@googlecode.com]

Updates:
Status: Fixed

Comment #14 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Closed by revision b0e0e343c5a7

[sele...@googlecode.com]

Comment #15 on issue 8083 by andrew.h...@ephox.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Thanks for that!

[sele...@googlecode.com]

Comment #16 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Issue 8171 has been merged into this issue.

[sele...@googlecode.com]

Comment #17 on issue 8083 by andrew.p...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Interestingly this issue does not occur in the .net port of 2.44.0...must
be implemented differently...

[sele...@googlecode.com]

Comment #18 on issue 8083 by threesix...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Just wondering if the release of 2.45 is far away?

[sele...@googlecode.com]

Comment #19 on issue 8083 by barancev: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

Issue 8467 has been merged into this issue.

[sele...@googlecode.com]

Comment #20 on issue 8083 by andrew.p...@gmail.com: Enum missing
https://code.google.com/p/selenium/issues/detail?id=8083

When is selenium 2.45 to be released?