Hi,
Sorry i was really busy in the last days. So here some comments:
- RepositoryMegamHook:80 You inject a "Provider<HttpClient> httpClientProvider", but you never use it.
- The constructor of MegamHookExecutor requires HttpClient and Repository but you never use them.
- The MegamHookExecutor defines a unused method called "createBaseEnvironment".
- The package "org.megam.scm_manager.data" can be removed, because the classes of this package are only used in a unused method.
- The class MegamHookResource uses the WebSecurityContext which is deprecated since version 1.22 of SCM-Manager. You should use "SecurityUtils.getSubject().checkRole(Role.Admin)" instead.
- Please do not use System.out in your code, please use the slf4j loggers.
- The pom includes a dependency to org.apache.commons:commons-jexl, but this dependency is never used.
- The pom defines SCM-Manager 1.35 as parent. This means that only instances of SCM-Manager 1.35 and above could use your plugin. I think you can safely use version 1.24 as parent, because your code does not use apis from version above 1.24.
- The plugin.xml shows my name as author and displays the url of the webhook-plugin.
If i have more time i will have a look at the frontend.
Sebastian