Code reviews
10 views
Skip to first unread message
Pjotr Prins
Jun 24, 2014, 6:18:19 AM6/24/14
to sciru...@googlegroups.com
Before Saturday all students should review some mentor code (discuss
with mentor). Mentors are also asked to review their student project.
Post at least 3 issues on github. Don't be afraid, mistakes are
allowed.
Look for:
- Code that is hard to understand
- Code that is underdocumented (i.e. not self explanatory)
- Code that has style issues (though tastes may differ)
- Code that lacks tests
- Project that lacks a good README
- Project that lacks API documentation
Pj.
with mentor). Mentors are also asked to review their student project.
Post at least 3 issues on github. Don't be afraid, mistakes are
allowed.
Look for:
- Code that is hard to understand
- Code that is underdocumented (i.e. not self explanatory)
- Code that has style issues (though tastes may differ)
- Code that lacks tests
- Project that lacks a good README
- Project that lacks API documentation
Pj.
Reply all
Reply to author
Forward
0 new messages