Qt - add "updated" flags to updateUi signal

27 views
Skip to first unread message

dail8859

unread,
Jun 23, 2017, 11:15:10 AM6/23/17
to scintilla-interest
The Qt ScintillaEditBase has the updateUi signal but doesn't carry the "updated" flags with it. This patch adds this parameter.

Also, there was a "updateUi" signal emitted from ScintillaEditBase::focusInEvent() but as far as I can tell this isn't needed at all...so it has been removed. Any thoughts about this particular line of code and if it is actually needed?

Thanks,
Justin
qt_updateui.patch

Neil Hodgson

unread,
Jun 23, 2017, 6:23:30 PM6/23/17
to scintilla...@googlegroups.com
dail8859:

> The Qt ScintillaEditBase has the updateUi signal but doesn't carry the "updated" flags with it. This patch adds this parameter.
>
> Also, there was a "updateUi" signal emitted from ScintillaEditBase::focusInEvent() but as far as I can tell this isn't needed at all...so it has been removed. Any thoughts about this particular line of code and if it is actually needed?

hg annotate says it is from the original commit so is likely from Jason Haslam / Software Toolworks - they may have more history.

Neil

Jason Haslam

unread,
Jun 23, 2017, 7:42:13 PM6/23/17
to scintilla...@googlegroups.com
I think that it was just a hack to signal clients to update when a different editor gets focus. It probably doesn’t belong there.

Jason
> --
> You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to scintilla-inter...@googlegroups.com.
> To post to this group, send email to scintilla...@googlegroups.com.
> Visit this group at https://groups.google.com/group/scintilla-interest.
> For more options, visit https://groups.google.com/d/optout.

Neil Hodgson

unread,
Jun 30, 2017, 10:41:35 PM6/30/17
to scintilla...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages