I was messing around with using Scintilla with Qt and came across a few minor issues. I'm very new to Qt so hopefully I'm not too off track. I apologize for not being able to make real patches right now but the changes are minor.
This simply adds the top ifndef and bottom endif. This is exactly how qt/ScintillaEdit/ScintillaDocument.h and qt/ScintillaEdit/ScintillaEdit.h file does checking for dll(import|export)
Secondly, the qt project files (ScintillaEditBase.pro, ScintillaEdit.pro, and ScintillaEditPy.pro) specify some SOURCE files using wildcards such as "../../lexers/*.cxx". This does not seem to cause a problem until you try to include one of these pro files in a parent project like this:
TEMPLATE = subdirs
CONFIG += ordered
SUBDIRS = Scintilla/qt/ScintillaEditBase/ScintillaEditBase.pro myapp/myapp.pro
myapp.depends = ScintillaEditBase
Relevant stack overflow discussion
https://stackoverflow.com/a/41121739 states that the wildcards can be specified like this "$$files(../../lexers/*.cxx, false)" though this does say qmake v3.0 is required.
Using: Win7, Qmake v3.1, Qt 5.9.0, Qt Creator 4.3.0
Thanks,
Justin